Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Make authlogic_facebook_login_button library independent #21

Closed
AppWhirl opened this Issue Jul 19, 2010 · 0 comments

Comments

Projects
None yet
2 participants

The authlogic_facebook_login_button method accepts a "js" option which supports prototype, and jquery libraries. The JavaScript part of this function simply gets an element by id, and calls the submit method on it. It will be nice to make it library independent by simply replacing various library specific implementations such as:

$('connect_to_facebook_form')
jQuery('#connect_to_facebook_form')

with

document.getElementById('connect_to_facebook_form')

The above method is cross-browser and works on all browsers as fari as I know. We wouldn't have to keep adding support for each individual library with this change. The file that the change would need to go in is authlogic_facebook_connect/helper.rb

@kalasjocke kalasjocke closed this Oct 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment