Joakim Ekberg kalasjocke

Organizations

@barefoothackers @tictail
kalasjocke commented on issue kalasjocke/hyp#11
@kalasjocke

@steveklabnik That's awesome news. I'll try to make it happen soon.

@kalasjocke

I haven't anything planned. But if you find time to implement it I would love a pull request.

@kalasjocke
Documenation Enhancement Regarding assets_protocol
@kalasjocke

Fixed.

@kalasjocke
Why assets_host works on production environment only?
@kalasjocke

Fixed.

@kalasjocke
@kalasjocke
@kalasjocke
Add notes on supported protocols and enable staging to mirror production
2 commits with 2 additions and 1 deletion
@kalasjocke

Thanks for till pull request @khelll!

@kalasjocke

Thanks! I should probably restructure the readme to reflect this.

@kalasjocke

No reason really. The staging and production environments should probably mirror each other as much as possible. Are you up for creating a pull req…

@kalasjocke

@igorrootsi Did you manage to come around and add tests for this new functionality?

kalasjocke commented on pull request kalasjocke/hyp#10
@kalasjocke

@lphuberdeau Yeah, bah. :cry:

@kalasjocke

@khelll Great stuff. I just added it to the readme: 94f68e2

@kalasjocke
  • @kalasjocke 94f68e2
    Add notes on Sinatra classic style
@kalasjocke
Usage with classic Sinatra style
@kalasjocke

If you can get hold of the app object in some way then yes, otherwise I would think it will get hard to define the rake task. Let me know if you fi…

kalasjocke commented on pull request kalasjocke/hyp#10
@kalasjocke

Alright, let's keep it this way then.

kalasjocke commented on pull request kalasjocke/hyp#10
@kalasjocke

I was referring to the fact that you were appending to the collector, not the internal structure. I like include_link, let's go with that if you're…

kalasjocke commented on pull request kalasjocke/hyp#10
@kalasjocke

I'm not sure I follow, could you give an example of a response with and the output being filtered?

kalasjocke commented on pull request kalasjocke/hyp#10
@kalasjocke

Yeah! I agree, perhaps append isn't the best. But perhaps we could go with append_link as you're appending it to the structure that will be produce…