updating fisher_swbd nnet3/chain scripts: removing non-chain training… #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… scripts, updating ivector training scripts,.etc
danpovey
reviewed
Jan 9, 2018
| @@ -112,8 +112,12 @@ srcdict=$srcdir/swb_ms98_transcriptions/sw-ms98-dict.text | |||
| # assume swbd_p1_data_prep.sh was done already. | |||
| [ ! -f "$srcdict" ] && echo "No such file $srcdict" && exit 1; | |||
|
|
|||
| rm -f $dir/lexicon0.txt | |||
There was a problem hiding this comment.
I don't like using -f to make rm quiet. do rm with 2>/dev/null.
| cp $srcdict $dir/lexicon0.txt || exit 1; | ||
| patch <local/dict.patch $dir/lexicon0.txt || exit 1; | ||
| chmod +x $srcdict $dir/lexicon0.txt |
There was a problem hiding this comment.
This doesn't make sense to me. why make them executable?
There was a problem hiding this comment.
sorry I meant +w. will fix
|
@xiaohui-zhang will do |
eginhard
pushed a commit
to eginhard/kaldi
that referenced
this pull request
Jan 11, 2018
danpovey
pushed a commit
that referenced
this pull request
Jan 23, 2018
mahsa7823
pushed a commit
to mahsa7823/kaldi
that referenced
this pull request
Feb 28, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Skaiste
pushed a commit
to Skaiste/idlak
that referenced
this pull request
Sep 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… scripts, updating ivector training scripts,.etc. @GaofengCheng please re-run and check in your latest chain model training scripts on top of this. Thanks.