Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependency conflict for issue #570

Closed
wants to merge 1 commit into from

Conversation

NeolithEra
Copy link

@NeolithEra
Copy link
Author

@Sispheor
Could you please help me review this issue?
Thank you very much!

BTW, dependency conflict problems are very common in practice in python ecosystem.
I have encountered the issues several times. What's your oppinion on the challenges of detecting and repairing such issues?
And how to avoid dependency conflict problems among python projects, especially from the ecosystem's perspective?

@Sispheor
Copy link
Member

Sispheor commented Aug 4, 2019

I told you that I want to discuss about this with another member of the project first.
Not sure if it's the best approach.
Even if we can be sure that kalliope will always use request, this lib is a direct dependency and should appears in the setup.
Also there is some other file to update to fix the docker and testing part.

@NeolithEra
Copy link
Author

NeolithEra commented Aug 4, 2019

@Sispheor Thanks for your feedback. Using transitive dependencies instead of direct dependencies may bring some risk. Please ignore this PR and discuss a better solution with another member. Please let me know your final decision, I can submit another PR to fix this problem. Thanks again.

@Sispheor
Copy link
Member

Sispheor commented Oct 2, 2019

@LaMonF what do you think about this one?
This lib is a used by a lot of other libs.

@Sispheor Sispheor changed the base branch from master to dev October 2, 2019 09:14
@Sispheor
Copy link
Member

Sispheor commented Oct 2, 2019

Ok for transitive dependencies then.
Could you update this line too?

@Sispheor Sispheor closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants