Permalink
Commits on Nov 6, 2017
Commits on Oct 30, 2017
  1. Fix timing issue with hostsetup script

    kalpik committed Oct 30, 2017
    I noticed that sometimes the port forwarding that we do using netsh doesn't work. The ECS agent does listen on port 51679, but we cannot connect to it using port 80, and hence IAM task roles don't work. I figured out that this happens when the netsh command is executed before the Credential IP is up. Maybe this is because we do the IP allocation in powershell, and then use netsh (cmd) to do the power forwarding. This change makes sure that the IP is up and responding before we try to set up port forwarding. And with this, I haven't noticed the issue anymore.
Commits on Sep 30, 2017
Commits on Sep 29, 2017
  1. Don't log websocket messages if there are errors.

    jhaynes committed Sep 29, 2017
    The messages that come over the websockets can potentially contain sensitive
    information that shouldn't be put in logs. Separately, if reading the message
    results in an error, the content of the message is irrelevant and unreliable.
Commits on Sep 28, 2017
  1. acs,tcs handlers: increase websocket rw timeout

    aaithal committed Sep 27, 2017
    Increase the websocket read and write timeouts
    as per review comments
  2. wsclient: add read and write deadlines

    aaithal committed Sep 27, 2017
    This commit aims to make the websocker connection management
    better by implementing the following improvements:
    
    1. Set read and write deadlines for websocket ReadMessage and
    WriteMessage operations. This is to ensure that these methods
    do not hang and result in io timeout if there's issues with
    the connection
    2. Reduce the scope of the lock in the Connect() method. The
    lock was being held for the length of Connect() method, which
    meant that it wouldn't be relnquished if there was any delay
    in establishing the connection. The scope of the lock has now
    been reduced to just accessing the cs.conn variable
    3. Start ACS heartbeat timer after the connection has been
    established. The timer was being started before a call to
    Connect, which meant that the connection could be prematurely
    terminated for being idle if there was a delay in establishing
    the connection
    
    These changes should improve the disconnection behavior of the
    websocket connection, which should help with scenarios where the
    Agent never reconnects to ACS because it's forever waiting in
    Disconnect() method waiting to acquire the lock (aws#985)
  3. Makefile: fix cni-plugins to build on OSX

    aaithal committed Sep 27, 2017
    The wc command prefixes spaces to the output, which
    corrupts the GIT_PORCELAIN variable, thus failing
    the build. This change removes spaces from the output.
  4. Merge pull request aws#956 from sharanyad/capadddrop

    sharanyad committed Sep 28, 2017
    ecs_client/model, functional_tests: updated model, functional tests for adding and dropping Linux capabilities
Commits on Sep 27, 2017
  1. ecs_client/model, functional_tests: Update to latest ECS API and Docu…

    sharanyad committed Sep 27, 2017
    …mentation, change agent version required
  2. ecs_client/model, functional_tests: updated model, functional tests f…

    sharanyad committed Aug 29, 2017
    …or adding and dropping Linux capabilities
    
    The changes include the following:
    - Model changes in ContainerDefinition of the form:
    linuxParameters: {
        capabilities: {
            add: [""],
            drop: [""]
        }
    }
    - Functional Tests that verify if the specified capability has been added to and dropped from the task's container
Commits on Sep 26, 2017
  1. ecscni: Re-implement removed AdditionalLocalRoutes

    samuelkarp committed Sep 26, 2017
    Code handling AdditionalLocalRoutes was inadvertently removed in
    10fb083.  This commit adds it back, and
    adjusts the TestSetupNS unit test to explicitly check for it.
  2. dependencygraph: Add new transition dependencies

    samuelkarp committed Sep 20, 2017
    Transition dependencies will deprecate and replace the
    SteadyStateDependencies list that exists in api.Container.  Transition
    dependencies could also replace implicit link- and volume-dependencies
    in the future, but that change is not yet planned.
Commits on Sep 25, 2017
  1. Merge pull request aws#980 from nmeyerhans/makefile-fixes

    nmeyerhans committed Sep 25, 2017
    Makefile fixes
  2. emptyvolume: Use nanoserver on Windows

    samuelkarp committed Sep 25, 2017
    microsoft/nanoserver:latest is significantly smaller than
    microsoft/windowsservercore:latest and should pull more quickly.
  3. engine: "internal" containers may not be pulled

    samuelkarp committed Sep 25, 2017
    This commit treats internal containers differently during the pull step
    of the container lifecycle.
    
    We currently have two types of internal containers: "empty host volume"
    containers and pause containers.  "Empty host volume" containers should
    either be pulled from a remote image (as on Windows) or imported from a
    locally-generated tarball (as on Linux).  The pause container image is
    either imported from a locally-embedded tarball inside the agent's
    rootfs or expected to already be present on the host (if the image is
    overridden via config).
Commits on Sep 19, 2017
  1. Add amazon-ecs-cni-plugins submodule

    nmeyerhans committed Sep 13, 2017
    Git status details are passed to the cni-plugins build-environment in order to
    cope with the way submodule .git directories are managed and how our container
    volume mounts break this approach.