Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tiny link protocol according to app protocol #870

Open
wants to merge 1 commit into
base: master
from

Conversation

@tomoya-saito
Copy link

tomoya-saito commented Oct 8, 2019

PR information

What is the current behavior?

Original code generates preview URLs that begin with “http” regardless of whether the Kaltura server is secure or non-secure.
So that, users cannot see correct short link URLs when they employ secure servers.
Today, I propose this change in order to display the correct URLs.

What is the new behavior?

The new code appends "http" or "https" to the short link URLs depending on whether the Kaltura server users are accessing is secure or non-secure.

Does this PR introduce a breaking change?

No.
This is a minor change for the system.

Original code generates preview URLs that begin with “http” regardless of whether the Kaltura server is secure or non-secure.
So that, users cannot see correct short link URLs when they employ secure servers.
Today, I propose this change in order to display the correct URLs.
@amirch1 amirch1 changed the title Update preview-embed.component.ts chore: update tiny link protocol according to app protocol Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.