You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When mwEmbed overrides the originalFlashembed, it is not maintaining this API and breaks integrations with flashembed that depend on them. mwEmbed should maintain the flashembed API in its override behavior.
The text was updated successfully, but these errors were encountered:
Do you mean when the katlura html5 library should support the flashembed api as it writes out the html5 player? ... i.e should getHTML should return something relevant in html5 mode? .. or should each method just be copy over a pointer to the original flashembed even if its somewhat incorrect in html5 rewrite contexts?
We could copy some of these APIs and implement them for kWidget.embed if they are relevant for html5 library...
What is the use case? which methods do you use?
I agree with Ran we should look for a use cases that are not already covered. Also it should be noted some of the flashembed functionality is already supported in kWidget.
They can just be pointers to the original methods. The use case is that code can be written to depend on those methods of flashembed, and mwEmbed breaks em. The issue isn't rendering KDP here, its the other N components that may use flashembed on a given HTML page.
flashembed is a function, but it also has static API methods on it. See doco and code for ref:
http://www.jquerytools.org/documentation/toolbox/flashembed.html
https://github.com/jquerytools/jquerytools/blob/master/src/toolbox/toolbox.flashembed.js
When mwEmbed overrides the originalFlashembed, it is not maintaining this API and breaks integrations with flashembed that depend on them. mwEmbed should maintain the flashembed API in its override behavior.
The text was updated successfully, but these errors were encountered: