Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML5 Fall Foward breaks flashembed static API #168

Closed
bbergstrom opened this issue Jun 11, 2012 · 4 comments
Closed

HTML5 Fall Foward breaks flashembed static API #168

bbergstrom opened this issue Jun 11, 2012 · 4 comments
Milestone

Comments

@bbergstrom
Copy link

flashembed is a function, but it also has static API methods on it. See doco and code for ref:
http://www.jquerytools.org/documentation/toolbox/flashembed.html
https://github.com/jquerytools/jquerytools/blob/master/src/toolbox/toolbox.flashembed.js

When mwEmbed overrides the originalFlashembed, it is not maintaining this API and breaks integrations with flashembed that depend on them. mwEmbed should maintain the flashembed API in its override behavior.

@mdale
Copy link

mdale commented Jun 12, 2012

Do you mean when the katlura html5 library should support the flashembed api as it writes out the html5 player? ... i.e should getHTML should return something relevant in html5 mode? .. or should each method just be copy over a pointer to the original flashembed even if its somewhat incorrect in html5 rewrite contexts?

@ranyefet
Copy link
Contributor

We could copy some of these APIs and implement them for kWidget.embed if they are relevant for html5 library...
What is the use case? which methods do you use?

@mdale
Copy link

mdale commented Jun 15, 2012

I agree with Ran we should look for a use cases that are not already covered. Also it should be noted some of the flashembed functionality is already supported in kWidget.

@bbergstrom
Copy link
Author

They can just be pointers to the original methods. The use case is that code can be written to depend on those methods of flashembed, and mwEmbed breaks em. The issue isn't rendering KDP here, its the other N components that may use flashembed on a given HTML page.

@mdale mdale closed this as completed in e40a836 Jul 4, 2012
@mdale mdale mentioned this issue Jul 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants