From da4935a9d3f9a188946a3bdb978174e7d9ad1707 Mon Sep 17 00:00:00 2001 From: ovp-github-actions Date: Wed, 10 Apr 2024 13:38:58 +0000 Subject: [PATCH 1/3] chore(release): 1.2.1 --- CHANGELOG.md | 2 ++ package.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 55b7990..50a7d3f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,8 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### 1.2.1 (2024-04-10) + ## 1.2.0 (2024-04-09) diff --git a/package.json b/package.json index 96fd07a..1d2d01e 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@playkit-js/playkit-js-downloads", - "version": "1.2.0", + "version": "1.2.1", "main": "dist/playkit-downloads.js", "homepage": "https://github.com/kaltura/playkit-js-downloads#readme", "scripts": { From c1fcd65f7e0fd38b85b134f897e72efc7c7c9b70 Mon Sep 17 00:00:00 2001 From: Tzipi <101048005+Tzipi-kaltura@users.noreply.github.com> Date: Sun, 14 Apr 2024 17:16:36 +0300 Subject: [PATCH 2/3] fix(FEC-13868): Player v7 | Download | Default language is being duplicated on kms. (#50) Issue: The first captions is being duplicated in the caption list Root cause: If there is no default caption (on the entry) player set the first captions form the list as the default and displays it on the download dialog, since caption.isDefault returns false we display this captions also in the hide captions so when user click on "More captions" he will see the first caption again. Solution: Check if caption is not the default by the user and it's not the default by the player. Solves FEC-13868 --- src/components/captions-list/captions-list.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/captions-list/captions-list.tsx b/src/components/captions-list/captions-list.tsx index fed8542..4c334bf 100644 --- a/src/components/captions-list/captions-list.tsx +++ b/src/components/captions-list/captions-list.tsx @@ -57,7 +57,7 @@ export const CaptionsList = withText({ const _renderCaptions = (captions: Array) => { return captions.map((caption: KalturaCaptionAsset) => { - if ((!caption.isDefault || caption.id !== defaultCaptions?.id) && caption.downloadUrl) { + if (!caption.isDefault && caption.id !== defaultCaptions?.id && caption.downloadUrl) { return _renderCaption(caption); } }); From 0b5b4d04bbe1a6dd7f6e2306f2c02f4cbf5020d3 Mon Sep 17 00:00:00 2001 From: ovp-github-actions Date: Thu, 2 May 2024 13:56:02 +0000 Subject: [PATCH 3/3] chore(release): 1.2.2 --- CHANGELOG.md | 7 +++++++ package.json | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 50a7d3f..dcf3309 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,13 @@ All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines. +### 1.2.2 (2024-05-02) + + +### Bug Fixes + +* **FEC-13868:** Player v7 | Download | Default language is being duplicated on kms. ([#50](https://github.com/kaltura/playkit-js-downloads/issues/50)) ([c1fcd65](https://github.com/kaltura/playkit-js-downloads/commit/c1fcd65f7e0fd38b85b134f897e72efc7c7c9b70)) + ### 1.2.1 (2024-04-10) ## 1.2.0 (2024-04-09) diff --git a/package.json b/package.json index 1d2d01e..ea18a8d 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "@playkit-js/playkit-js-downloads", - "version": "1.2.1", + "version": "1.2.2", "main": "dist/playkit-downloads.js", "homepage": "https://github.com/kaltura/playkit-js-downloads#readme", "scripts": {