Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7 modifications cont'd #3459

Merged

Conversation

@jessp01
Copy link
Contributor

commented Nov 9, 2015

No description provided.

@jessp01

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2015

  • Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead
  • Methods with the same name as their class will not be constructors in a future version of PHP

I believe I got all the instances of constructors with the class name.
For future ref, done with:

$ find . -type f -name "*.php" -exec grep "\s*class [a-zA-Z+]"  {} -H \;|awk -F " " '{print $1" "$2}' > /tmp/classes.log
while read LINE;do
    CLASS=`echo $LINE | awk -F " " '{print $NF}'`
    FILE=`echo $LINE | awk -F ":" '{print $1}'`
    grep -H "function $CLASS\s*(" $FILE
done < /tmp/classes.log

@jessp01 jessp01 changed the title Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead PHP 7 modifications cont'd Nov 9, 2015

tan-tan-kanarek added a commit that referenced this pull request Nov 9, 2015

@tan-tan-kanarek tan-tan-kanarek merged commit 962449b into kaltura:Kajam-11.2.0 Nov 9, 2015

jessp01 added a commit to jessp01/server that referenced this pull request Nov 18, 2015

etameran added a commit that referenced this pull request Nov 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.