Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-9262 handle thumb and volume mapped with encryption at rest #7625

Merged
merged 4 commits into from Oct 7, 2018

Conversation

Projects
None yet
2 participants
@gotlieb
Copy link
Contributor

commented Oct 3, 2018

return self::curlThumbUrlWithOffset($flavorUrl, $calc_vid_sec, $packagerCaptureUrl, $capturedThumbPath, $width, $height);
}
private static function buildThumbUrl($entry, $flavorAsset)

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Oct 4, 2018

Contributor

Move to protected (according to new Coding Standard)

@@ -1142,16 +1171,12 @@ public static function captureLocalThumb($entry, $capturedThumbPath, $calc_vid_s
return true;
}
public static function captureLocalThumbUsingPackager($entry, $capturedThumbPath, $calc_vid_sec, &$flavorAssetId, $width, $height)
public static function captureLocalThumbUsingPackager($flavorAsset, $capturedThumbPath, $calc_vid_sec, &$flavorAssetId, $width, $height)

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Oct 4, 2018

Contributor

Either validate that flavorAsset is valid , or move the function to protected.

Show resolved Hide resolved alpha/apps/kaltura/lib/myEntryUtils.class.php

@gotlieb gotlieb changed the title Naos 14.6.0 plat 9262 PLAT-9262 handle thumb and volume mapped with encryption at rest Oct 7, 2018

@gotlieb gotlieb merged commit 453bcf8 into Naos-14.6.0 Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.