New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naos 14.8.0 sup 15616 #7803

Merged
merged 3 commits into from Nov 11, 2018

Conversation

Projects
None yet
2 participants
@MosheMaorKaltura
Contributor

MosheMaorKaltura commented Nov 8, 2018

No description provided.

@MosheMaorKaltura MosheMaorKaltura merged commit 6ff5421 into Naos-14.8.0 Nov 11, 2018

@MosheMaorKaltura MosheMaorKaltura deleted the Naos-14.8.0-SUP-15616 branch Nov 11, 2018

foreach($operationAttributes as $singleAttribute)
{
KalturaLog::info("Going To create Flavor for clip: " . print_r($singleAttribute));
KalturaLog::info("Going To create Flavor for clip: " . print_r($singleAttribute, true));

This comment has been minimized.

@jessp01

jessp01 Nov 15, 2018

Contributor

@MosheMaorKaltura - IMHO,

KalturaLog::info("Going To create Flavor for clip: " . print_r($singleAttribute, true));

Should be moved to line 318 since if the condition in line 313 evaluates as true, execution will skip to the next iteration and "Ingnoring clip attribute with non-positive duration" will be logged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment