New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-9399: allow bulk activate/reject for category entries #7824

Merged
merged 7 commits into from Nov 19, 2018

Conversation

Projects
None yet
2 participants
@inbal-ben-david
Contributor

inbal-ben-david commented Nov 13, 2018

No description provided.

@inbal-ben-david inbal-ben-david changed the title from Naos 14.8.0 plat 9399 to PLAT-9399: allow bulk activate/reject for category entries Nov 14, 2018

{
$this->handleResultError($bulkUploadResult, KalturaBatchJobErrorTypes::KALTURA_API, $requestResult['message']);
$bulkUploadResult->objectStatus = $requestResult['code'];
$this->addBulkUploadResult($bulkUploadResult);

This comment has been minimized.

@MosheMaorKaltura

MosheMaorKaltura Nov 19, 2018

Contributor

Small refactor -
No need
addBulkUploadResult / continue
Since it is only called once at the end of the loop.

protected function updateObjectsResults(array $requestResults, array $bulkUploadResults)
{
KalturaLog::info("Updating " . count($requestResults) . " results");
$dummy = array();

This comment has been minimized.

@MosheMaorKaltura

MosheMaorKaltura Nov 19, 2018

Contributor

This var is actually the multi request results of the updateObjectsResults.
Please rename to a more meaningful name.

$this->handleMultiRequest($dummy,true);
}
private function handleMultiRequest(&$ret,$finish=false)

This comment has been minimized.

@MosheMaorKaltura

MosheMaorKaltura Nov 19, 2018

Contributor

Use protected (Coding standard).

$this->handleMultiRequest($dummy,true);
}
private function handleMultiRequest(&$ret,$finish=false)

This comment has been minimized.

@MosheMaorKaltura

MosheMaorKaltura Nov 19, 2018

Contributor

space after ,

@@ -431,5 +431,52 @@ function abortAction($id)
return $ret;
}
/**
* @action activateCategoryEntries

This comment has been minimized.

@MosheMaorKaltura

MosheMaorKaltura Nov 19, 2018

Contributor

rename action annotation

@inbal-ben-david inbal-ben-david changed the base branch from Naos-14.8.0 to Naos-14.9.0 Nov 19, 2018

@inbal-ben-david inbal-ben-david merged commit 5f87f52 into Naos-14.9.0 Nov 19, 2018

@inbal-ben-david inbal-ben-david deleted the Naos-14.8.0-PLAT-9399 branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment