New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding check for tag in copied copy cue point #7907

Merged
merged 5 commits into from Dec 9, 2018

Conversation

Projects
None yet
2 participants
@david-winder-kaltura
Copy link
Contributor

david-winder-kaltura commented Dec 9, 2018

No description provided.

david-winder-kaltura added some commits Dec 9, 2018

@@ -14,7 +14,7 @@ protected function shouldCopyCuePoint($cuePoint)
$cuePointEndTime = $this->getOffsetForTimestamp($cuePoint->calculatedEndTime * 1000, false);
KalturaLog::debug("Checking times to know if copy is needed for id[". $cuePoint->id ."]: start- [$cuePointStartTime], end- [$cuePointEndTime], calculatedEndTime - " . $cuePoint->calculatedEndTime);
if ($cuePointStartTime < 0 && is_null($cuePoint->calculatedEndTime))

This comment has been minimized.

@MosheMaorKaltura

MosheMaorKaltura Dec 9, 2018

Contributor

Add brackets for single if line (New coding standard)

/**
* @param KalturaCuePoint $cuePoint
* @return boolean
*/

This comment has been minimized.

@MosheMaorKaltura

MosheMaorKaltura Dec 9, 2018

Contributor

Function rename checkShouldCopyCuePointBeforeTimeWindow -> shouldCopyCuePointBeforeTimeWindow
or shouldCopyBasedOnTags and just send it the tags list, also - is it relevant to all cue point types or only to a specific type, if it is relevant to a specific type then I will set this function only on the relevant cue point object.

david-winder-kaltura added some commits Dec 9, 2018

@david-winder-kaltura david-winder-kaltura merged commit 01de9ea into Naos-14.10.0 Dec 9, 2018

@david-winder-kaltura david-winder-kaltura deleted the Naos-14.10.0-PLAT-9477-AddingCuePointTagCheck branch Dec 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment