Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partner ID check for storage profile retrieval by ID #8021

Merged
merged 2 commits into from Dec 25, 2019

Conversation

@hilak
Copy link
Contributor

hilak commented Jan 15, 2019

No description provided.

@hilak hilak requested a review from MosheMaorKaltura Jan 15, 2019
@yossipapi

This comment has been minimized.

Copy link
Contributor

yossipapi commented Jan 17, 2019

Why not simply call $this->applyPartnerFilterForClass('storageProfile'); in the init service wouldn't it achive the same.

$dbStorageProfile = StorageProfilePeer::retrieveByPK($storageProfileId);
$dbStorageProfile = StorageProfilePeer::retrieveByIdAndPartnerId($storageProfileId, $dbAsset->getPartnerId());

This comment has been minimized.

Copy link
@yossipapi

yossipapi Jan 17, 2019

Contributor

Indent.

@kaltura-hooks

This comment has been minimized.

Copy link

kaltura-hooks commented Jan 26, 2019

Hi @hilak,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

@MosheMaorKaltura MosheMaorKaltura changed the base branch from Naos-14.12.0 to Orion-15.14.0 Dec 25, 2019
@MosheMaorKaltura MosheMaorKaltura merged commit 053bf7b into Orion-15.14.0 Dec 25, 2019
2 checks passed
2 checks passed
Datree Smart Policy Best Practices Verification
Details
Datree insights datreeio insights events
Details
@MosheMaorKaltura MosheMaorKaltura deleted the Naos-14.12.0-PLAT-9579 branch Dec 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.