New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-9602: extract thumbnail stripe from segment of the video #8039

Merged
merged 2 commits into from Jan 23, 2019

Conversation

Projects
None yet
2 participants
@inbal-ben-david
Copy link
Contributor

inbal-ben-david commented Jan 23, 2019

No description provided.

@inbal-ben-david inbal-ben-david merged commit d87b2c7 into Naos-14.13.0 Jan 23, 2019

@inbal-ben-david inbal-ben-david deleted the Naos-14.13.0-PLAT-9602 branch Jan 23, 2019

@@ -3487,7 +3487,7 @@ protected function getTrackEntryString ($namespace, $customDataColumn, $value)
* @return the thumbnail path.
*/
public function getLocalThumbFilePath($version , $width , $height , $type , $bgcolor ="ffffff" , $crop_provider=null, $quality = 0,
$src_x = 0, $src_y = 0, $src_w = 0, $src_h = 0, $vid_sec = -1, $vid_slice = 0, $vid_slices = -1, $density = 0, $stripProfiles = false, $flavorId = null, $fileName = null)

This comment has been minimized.

@noam-arad

noam-arad Jan 27, 2019

Contributor

You made a change to the signature of entry.php::getLocalThumbFilePath, this is overridden by LiveEntry.php::getLocalThumbFilePath, you should change the signature of LiveEntry.php as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment