Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plat 9889 : Add support in eSearch aggregations #8504

Merged
merged 38 commits into from Jul 10, 2019

Conversation

@MosheMaorKaltura
Copy link
Contributor

commented Jun 3, 2019

No description provided.

@MosheMaorKaltura MosheMaorKaltura changed the title Orion 15.1.0 plat 9889 1 Plat 9889 : Add support in eSearch aggregations Jun 4, 2019

@MosheMaorKaltura MosheMaorKaltura changed the base branch from Orion-15.1.0 to Orion-15.3.0 Jul 9, 2019

private static $map_between_objects = array(
'size',
'fieldName'

This comment has been minimized.

Copy link
@ZurKaltura

ZurKaltura Jul 9, 2019

Contributor

$fieldName doesn't exists in this class

{
$responseBucket = new KalturaESearchAggregationBucket();
$responseBucket->fromArray($bucket);
if($fieldName === ESearchCuePointsAggregationFieldName::TYPE)

This comment has been minimized.

Copy link
@ZurKaltura

ZurKaltura Jul 9, 2019

Contributor

Should compare $fieldName to the API enum, not to the core enum as it seems to be API since we assign it to aggs->fieldName

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 10, 2019

Author Contributor

Checking the returned value from the core.

@@ -1,215 +1,224 @@
<?php

This comment has been minimized.

Copy link
@ZurKaltura

ZurKaltura Jul 9, 2019

Contributor

for some reason, it thinks you changed the whole file is there a way to prevent it?

$agg->fieldName = $fieldName;
$agg->name = ESearchCategoryAggregationItem::KEY;
$bucketsArray = new KalturaESearchAggregationBucketsArray();
$buckets = $coreResponse[ESearchAggregations::BUCKETS];

This comment has been minimized.

Copy link
@gotlieb

gotlieb Jul 10, 2019

Contributor

$coreResponse should be validated.

*/
protected $size;
protected $fieldName;

This comment has been minimized.

Copy link
@gotlieb

gotlieb Jul 10, 2019

Contributor

missing @var type

$this->size = $size;
}
public function getFieldName()

This comment has been minimized.

Copy link
@gotlieb

gotlieb Jul 10, 2019

Contributor

missing notations

return $this->fieldName;
}
public function setFieldName($fieldName)

This comment has been minimized.

Copy link
@gotlieb

gotlieb Jul 10, 2019

Contributor

missing notations

@MosheMaorKaltura MosheMaorKaltura merged commit c28cd83 into Orion-15.3.0 Jul 10, 2019

@MosheMaorKaltura MosheMaorKaltura deleted the Orion-15.1.0-PLAT-9889-1 branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.