Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-9841:block ability to use loginByLoginId with partner configuration #8541

Merged
merged 3 commits into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@ravitshalem
Copy link
Contributor

commented Jun 13, 2019

No description provided.

@@ -214,6 +215,9 @@ protected function loginImpl($puserId, $loginEmail, $password, $partnerId = null
else if ($code == kUserException::MISSING_OTP) {
throw new KalturaAPIException(KalturaErrors::MISSING_OTP);
}
else if ($code == kUserException::DIRECT_LOGIN_BLOCKED) {

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jun 13, 2019

Contributor

String comparison is always === or strcmp

@ravitshalem ravitshalem merged commit e2f7f70 into Orion-15.1.0 Jun 13, 2019

@ravitshalem ravitshalem deleted the Orion-15.1.0-PLAT-9841 branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.