Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partner->getSecrets() should accept the optional $otp and pass it on to userLoginByEmail() #8622

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@jessp01
Copy link
Contributor

commented Jul 8, 2019

At the moment, attempting to call this function when OTP was enabled on the partner will fail.

partner->getSecrets() should accept the option $otp and pass it along…
… to userLoginByEmail()

At the moment, attempting to call this function when OTP was enabled on the partner will fail.
@jessp01

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

@yossipapi, @MosheMaorKaltura - IMHO, this warrants a hotfix.
This also prevents the developer.kaltura.com login flow from working when OTP has been enabled on the partner.

@jessp01 jessp01 changed the title partner->getSecrets() should accept the option $otp and pass it along userLoginByEmail() partner->getSecrets() should accept the optional $otp and pass it along userLoginByEmail() Jul 8, 2019

@jessp01 jessp01 changed the title partner->getSecrets() should accept the optional $otp and pass it along userLoginByEmail() partner->getSecrets() should accept the optional $otp and pass it on to userLoginByEmail() Jul 8, 2019

jessp01 added a commit to kaltura/developer-platform that referenced this pull request Jul 8, 2019

@MosheMaorKaltura MosheMaorKaltura merged commit ece884d into Orion-15.3.0 Jul 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.