Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-9998:Adding new type of userEntry called watch later #8647

Merged
merged 5 commits into from Jul 16, 2019

Conversation

@ravitshalem
Copy link
Contributor

commented Jul 15, 2019

No description provided.

*/
public static function isAllowedPartner($partnerId)
{
if (in_array($partnerId, array(Partner::ADMIN_CONSOLE_PARTNER_ID, Partner::BATCH_PARTNER_ID)))

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 16, 2019

Contributor

Just return true as it is going to be allowed for all partners.

public static function getWatchLaterPlaylistUserEntryTypeCoreValue ($valueName)
{
$value = self::getPluginName() . IKalturaEnumerator::PLUGIN_VALUE_DELIMITER . $valueName;

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 16, 2019

Contributor

$value = self:: getApiValue(#value)

* Plugin enabling the storage of entries that relates to a user in a watch later playlist
* @package plugins.watchLaterPlaylist
*/
class WatchLaterPlaylistPlugin extends KalturaPlugin implements IKalturaPermissions, IKalturaEnumerator, IKalturaObjectLoader

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 16, 2019

Contributor

rename all code from WatchLaterPlaylist to WatchLater

{
return array('WatchLaterPlaylistUserEntryType');
}
if ($baseEnumName == 'UserEntryType')

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 16, 2019

Contributor

string compare ===

public static function loadObject($baseClass, $enumValue, array $constructorArgs = null)
{
if ( ($baseClass == "KalturaUserEntry") && ($enumValue == self::getWatchLaterPlaylistUserEntryTypeCoreValue(WatchLaterPlaylistUserEntryType::WATCH_LATER_PLAYLIST)))

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 16, 2019

Contributor

staring with no arguments always single quote

@ravitshalem ravitshalem changed the title PLAT-9998:Adding new type of userEntry called watch later playlist PLAT-9998:Adding new type of userEntry called watch later Jul 16, 2019

@ravitshalem ravitshalem merged commit 527ec52 into Orion-15.3.0 Jul 16, 2019

@ravitshalem ravitshalem deleted the Orion-15.3.0-PLAT-9998 branch Jul 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.