Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10026:validate domains from partner configuration allowed from email whitelist #8679

Merged
merged 8 commits into from Jul 30, 2019

Conversation

@ravitshalem
Copy link
Contributor

commented Jul 28, 2019

No description provided.

else
{
$domainsNotAllowed[$domain] = $domain;
KalturaLog::debug(print_r("$domain is not allowing Kaltura\n",true));

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 29, 2019

Contributor

Print_r not needed

* @subpackage general
*/
class kDomainsValidation

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 29, 2019

Contributor

rename to kSpfMailerValidator

if ($this->allowedFromEmailWhiteList)
{
$fromEmailList = array_map('trim',explode(',',$this->allowedFromEmailWhiteList));
$domainsNotAllowed = kDomainsValidation::getDomainsNotAllowed($fromEmailList);

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jul 29, 2019

Contributor

fromEmailList - should contain email domains.

@MosheMaorKaltura

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

reviewed

@ravitshalem ravitshalem merged commit 1e1f24d into Orion-15.4.0 Jul 30, 2019

@ravitshalem ravitshalem deleted the Orion-15.4.0-PLAT-10026 branch Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.