Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10050:adding support in L3 CDN tokenizer #8700

Merged
merged 10 commits into from Aug 19, 2019

Conversation

@ravitshalem
Copy link
Contributor

commented Aug 13, 2019

No description provided.

{
$commonPartUrl = substr($url, 0, $flavorIdPos) . self::FLAVOR_ID . self::SLASH;
}
$restUrl = '';

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Aug 14, 2019

Contributor

This var is not really needed

$lastSlashOccurrence = strrpos ($url, self::SLASH) + 1;
if ($lastSlashOccurrence === false)
{
return array('', '');

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Aug 14, 2019

Contributor

You will never get here since you are adding +1 to the strpos

@ravitshalem ravitshalem changed the base branch from Orion-15.5.0 to Orion-15.6.0 Aug 19, 2019

@ravitshalem ravitshalem merged commit 3d7bf82 into Orion-15.6.0 Aug 19, 2019

@ravitshalem ravitshalem deleted the Orion-15.5.0-PLAT-10050 branch Aug 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.