Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10100: The trim() function is not, by default, unicode safe. #8741

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@jessp01
Copy link
Contributor

commented Sep 2, 2019

Thus, on certain machines, if such trailing Unicode characters exist, a complete failure will occur as described in https://kaltura.atlassian.net/browse/PLAT-10100

This change fixes it. Verified on qa-apache-php7 where, before the
change, I was able to reproduce it.

The trim() function is not, by default, unicode safe.
Thus, on certain machines, if such trailing Unicode characters exist, a complete failure will occur as described in https://kaltura.atlassian.net/browse/PLAT-10100

This change fixes it. Verified on qa-apache-php7 where, before the
change, I was able to reproduce it.
@jessp01

This comment has been minimized.

Copy link
Contributor Author

commented Sep 2, 2019

For additional context, the actual failure occurs here:
https://github.com/kaltura/server/blob/Orion-15.6.0/plugins/bulk_upload/csv/batch/BulkUploadUserEngineCsv.php#L48

Following the trim() done here:
https://github.com/kaltura/server/blob/Orion-15.6.0/plugins/bulk_upload/csv/batch/BulkUploadUserEngineCsv.php#L33

In the batch/bulkupload-0-$STAMP.log, for the input file attached to the ticket, you will see:

[BATCH] [BulkUploadUserEngineCsv->createUploadResult] INFO: Value userId is empty
[BATCH] [BulkUploadUserEngineCsv->createUploadResult] INFO: Value email is empty

@jessp01 jessp01 changed the title The trim() function is not, by default, unicode safe. PLAT-10100: The trim() function is not, by default, unicode safe. Sep 2, 2019

@yossipapi yossipapi merged commit fc41b35 into Orion-15.6.0 Sep 3, 2019

@yossipapi yossipapi deleted the fix-PLAT-10100 branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.