Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10200:Add ability search history indexing per partner #8784

Merged
merged 1 commit into from Sep 24, 2019

Conversation

@MosheMaorKaltura
Copy link
Contributor

MosheMaorKaltura commented Sep 24, 2019

No description provided.

@ZurKaltura

This comment has been minimized.

Copy link
Contributor

ZurKaltura commented Sep 24, 2019

Hi,

I think we should consider to also return an exception when we try to retrieve search history for a partner that it search history disabled so it will be clear for the partner why it doesn't get results.

This also affects the KMS since they query for last searches they need to change their to logic to see if the partner have history disabled otherwise we will get tickets from people who don't have the right terms when they look at their history.

@MosheMaorKaltura

This comment has been minimized.

Copy link
Contributor Author

MosheMaorKaltura commented Sep 24, 2019

Since this feature only disables new indexing I see no point in blocking history search that may contain valid content.

@MosheMaorKaltura MosheMaorKaltura merged commit ec7317c into Orion-15.8.0 Sep 24, 2019
@MosheMaorKaltura MosheMaorKaltura deleted the Orion-15.8.0-PLAT-10200 branch Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.