Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10216:update last login when login with sso #8806

Merged
merged 5 commits into from Oct 16, 2019

Conversation

@ravitshalem
Copy link
Contributor

ravitshalem commented Oct 13, 2019

No description provided.

@@ -557,6 +557,12 @@ private static function userLogin(UserLoginData $loginData = null, $password, $p
}
}
self::setLastLoginFields($loginData, $kuser);
return $kuser;

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Oct 15, 2019

Contributor

In case of user that was just created, its id will be generated only after calling save.
Therefor ** setLastLoginFields** must return the kuser after save.

}
$sso = new KalturaSso();
$sso->fromObject($dbSso, $this->getResponseProfile());
return $sso->redirectUrl;
}
protected static function setLastLogin($partnerId, $userId)
{
kuserPeer::setUseCriteriaFilter(false); //action is without ks, need to prevent the addition of partnerId 0 into the criteria

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Oct 15, 2019

Contributor

Need to validate partnerId is not 0

@ravitshalem ravitshalem merged commit d427df9 into Orion-15.9.0 Oct 16, 2019
2 checks passed
2 checks passed
Datree Smart Policy Best Practices Verification
Details
Datree insights datreeio insights events
Details
@ravitshalem ravitshalem deleted the Orion-15.9.0-PLAT-10216 branch Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.