Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kava - add QOE reports #8889

Merged
merged 9 commits into from Nov 12, 2019
Merged

Kava - add QOE reports #8889

merged 9 commits into from Nov 12, 2019

Conversation

@NadavHarnik
Copy link
Contributor

NadavHarnik commented Nov 11, 2019

No description provided.

{
if (kConf::hasParam('kava_skip_date_rounding_client_tags'))
{
$skipDateRoundingClientTags = kConf::get('kava_skip_date_rounding_client_tags');

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Nov 12, 2019

Contributor

Better usage call kConf::get with default value rather than calling kConf::hasParam and kConf::get.

@NadavHarnik NadavHarnik merged commit cfbc65b into Orion-15.11.0 Nov 12, 2019
2 checks passed
2 checks passed
Datree Smart Policy Best Practices Verification
Details
Datree insights datreeio insights events
Details
@NadavHarnik NadavHarnik deleted the Orion-15.7.0-QOE branch Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.