Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-10245 - Move all configurations from file system to db map - pha… #8890

Merged
merged 13 commits into from Nov 18, 2019

Conversation

@gotlieb
Copy link
Contributor

gotlieb commented Nov 11, 2019

…se 1 - align conf_maps service

@MosheMaorKaltura

…se 1 - align conf_maps service
alpha/config/cache/kRemoteMemCacheConf.php Outdated Show resolved Hide resolved
alpha/config/cache/kRemoteMemCacheConf.php Outdated Show resolved Hide resolved
alpha/config/cache/kRemoteMemCacheConf.php Outdated Show resolved Hide resolved
alpha/config/cache/kRemoteMemCacheConf.php Outdated Show resolved Hide resolved
alpha/config/cache/kRemoteMemCacheConf.php Outdated Show resolved Hide resolved
alpha/config/kConfCacheManager.php Outdated Show resolved Hide resolved
alpha/scripts/utils/syncDbConfigMapsToCache.php Outdated Show resolved Hide resolved
alpha/scripts/utils/syncDbConfigMapsToCache.php Outdated Show resolved Hide resolved
infra/general/iniUtils.php Outdated Show resolved Hide resolved
infra/general/iniUtils.php Outdated Show resolved Hide resolved
Copy link
Contributor

MosheMaorKaltura left a comment

General remarks -

  1. Use single quotes for strings without processing.
  2. Try to keep functions small , if needed break the code into 2 or more functions.
  3. prefer using PHP_EOL instead of "\n"
infra/general/iniUtils.php Show resolved Hide resolved
* @return string
*/
public static function arrayToIniString(array $iniData)
public static function arrayToIniString($ini, $isBaseLevel = true, $baseKey = null)

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Nov 12, 2019

Contributor

Must run a test vector on this function using all ini's that been called by the system today and make sure we don't break in spacial cases

$filter = new KalturaConfMapsFilter();
$filter->relatedHostEqual = $this->relatedHost;
$filter->nameEqual = $this->name;
kApiCache::disableCache();

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Nov 12, 2019

Contributor

Why did you need to disable api cache at this point

This comment has been minimized.

Copy link
@gotlieb

gotlieb Nov 12, 2019

Author Contributor

since you are retrieving the full map and you might not have the updated content in your cache.

plugins/conf_maps/lib/api/KalturaConfMaps.php Outdated Show resolved Hide resolved
plugins/conf_maps/lib/api/KalturaConfMaps.php Outdated Show resolved Hide resolved
plugins/conf_maps/lib/api/KalturaConfMaps.php Outdated Show resolved Hide resolved
plugins/conf_maps/lib/api/KalturaConfMaps.php Outdated Show resolved Hide resolved
root and others added 3 commits Nov 12, 2019
root
root
gotlieb and others added 9 commits Nov 12, 2019
root
root
root
root
root
@gotlieb gotlieb merged commit fb5cf60 into Orion-15.11.0 Nov 18, 2019
2 checks passed
2 checks passed
Datree Smart Policy Best Practices Verification
Details
Datree insights datreeio insights events
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.