Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orion 15.15.0 live details #9129

Merged
merged 12 commits into from Jan 28, 2020
Merged

Orion 15.15.0 live details #9129

merged 12 commits into from Jan 28, 2020

Conversation

@noam-arad
Copy link
Contributor

noam-arad commented Jan 26, 2020

No description provided.

@@ -296,6 +296,10 @@ public function getLastBroadcastEndTime ( ) { return (int) $this->getFromCustom
public function setLastCuePointSyncTime ( $v ) { $this->putInCustomData ( "last_cue_point_sync_time" , $v ); }
public function getLastCuePointSyncTime ( ) { return (int) $this->getFromCustomData("last_cue_point_sync_time"); }

public function setAnyBroadcastTime( $v ) { $this->putInCustomData ( "any_broadcast" , $v ); }

This comment has been minimized.

Copy link
@noam-arad

noam-arad Jan 27, 2020

Author Contributor

move any_broadcast to CONST

KalturaResponseCacher::setConditionalCacheExpiry(self::ISLIVE_ACTION_NON_KALTURA_LIVE_CONDITIONAL_CACHE_EXPIRY);
if(in_array($liveStreamEntry->getSource(), array(KalturaSourceType::LIVE_STREAM, KalturaSourceType::LIVE_STREAM_ONTEXTDATA_CAPTIONS)))
{
$res = new KalturaLiveStreamDetails();

This comment has been minimized.

Copy link
@noam-arad

noam-arad Jan 27, 2020

Author Contributor

should be separate method

$res->secondaryStreamStatus = $currESN->getStatus();
}
}
$res->viewMode = $liveStreamEntry->getViewMode();

This comment has been minimized.

Copy link
@noam-arad

noam-arad Jan 27, 2020

Author Contributor

missing responseHandlingIsLive

@noam-arad noam-arad merged commit 9644ac8 into Orion-15.16.0 Jan 28, 2020
@noam-arad noam-arad deleted the Orion-15.15.0-liveDetails branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.