Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUP-20681: fix Zoom 'expire_in' incorrect calculation + small refactor #9139

Merged
merged 9 commits into from Jan 30, 2020

Conversation

@amiras89
Copy link
Contributor

amiras89 commented Jan 28, 2020

No description provided.

@amiras89 amiras89 requested review from MosheMaorKaltura and ZurKaltura Jan 28, 2020
$expiresIn = $tokensData[self::EXPIRES_IN];
$tokensData[self::EXPIRES_IN] = self::getValidUntil($expiresIn);
return self::extractTokensFromData($tokensData);
return $tokensData;

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jan 29, 2020

Contributor

no need to return

*/
public static function getValidUntil($expiresIn)
public static function setTokenExpiryAbsoluteTime($tokenData)

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jan 29, 2020

Contributor

call by ref

* @param array $tokenData
* @return array $tokenData
*/
public static function setTokenExpiryRelativeTime($tokenData)

This comment has been minimized.

Copy link
@MosheMaorKaltura

MosheMaorKaltura Jan 29, 2020

Contributor

call by ref

@amiras89

This comment has been minimized.

Copy link
Contributor Author

amiras89 commented Jan 29, 2020

@MosheMaorKaltura tested Zoom after adding "retrieveTokenData()" - works like a charm

@amiras89 amiras89 merged commit 47b7764 into Orion-15.16.0 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.