From 48de750550dd12016e957d60e0ae57e59944558d Mon Sep 17 00:00:00 2001 From: Chris Double Date: Wed, 23 Sep 2015 22:21:41 +1200 Subject: [PATCH] sqlops: Fix memory leak in error condition - Fix pv_parse_dbr_name to free spv if the key is unknown. - Fix typo in error log in pv_parse_dbr_name. --- modules/sqlops/sql_var.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/modules/sqlops/sql_var.c b/modules/sqlops/sql_var.c index 940ec5a7947..20ec6725140 100644 --- a/modules/sqlops/sql_var.c +++ b/modules/sqlops/sql_var.c @@ -257,7 +257,9 @@ int pv_parse_dbr_name(pv_spec_p sp, str *in) if(p>in->s+in->len || *p=='\0' || *p!=']') goto error_index; } else { - LM_ERR("unknow key [%.*s]\n", pvs.len, pvs.s); + LM_ERR("unknown key [%.*s]\n", pvs.len, pvs.s); + if(spv!=NULL) + pkg_free(spv); return -1; } sp->pvp.pvn.u.dname = (void*)spv;