From 5f3ed08b5e234465d4fb909460367a63ed63a550 Mon Sep 17 00:00:00 2001 From: Victor Seva Date: Tue, 9 May 2023 23:28:04 +0200 Subject: [PATCH] dialplan: fix ki_dp_translate() checks for input/output parameters fixes #3447 (cherry picked from commit ab0a2be6b522c1b48a2442447c24e7ab156e3d4e) --- src/modules/dialplan/dialplan.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/modules/dialplan/dialplan.c b/src/modules/dialplan/dialplan.c index fb57faa55d1..26c68f777fd 100644 --- a/src/modules/dialplan/dialplan.c +++ b/src/modules/dialplan/dialplan.c @@ -872,9 +872,12 @@ static int ki_dp_translate(sip_msg_t* msg, int id, str *input_spv, str *output_s if (!msg) return -1; - if (input_spv == NULL || input_spv->s == NULL || input_spv->len <= 0 || - output_spv == NULL || output_spv->s == NULL || output_spv->len <= 0) { - LM_ERR("invalid destination var name for input or output\n"); + if (input_spv != NULL && (input_spv->s == NULL || input_spv->len <= 0)) { + LM_ERR("invalid destination var name for input\n"); + return -1; + } + if (output_spv != NULL && (output_spv->s == NULL || output_spv->len <= 0)) { + LM_ERR("invalid destination var name for output\n"); return -1; }