From ab17b6811c94730f6428c218c9587d6365c9faa5 Mon Sep 17 00:00:00 2001 From: Pantelis Kolatsis Date: Wed, 29 Mar 2023 09:29:53 +0000 Subject: [PATCH] pdb: convert to memory logging helper, properly free memory in error cases --- src/modules/pdb/pdb.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/modules/pdb/pdb.c b/src/modules/pdb/pdb.c index c6656ee62b5..e818b06efb3 100644 --- a/src/modules/pdb/pdb.c +++ b/src/modules/pdb/pdb.c @@ -541,6 +541,7 @@ static int add_server(char *host, char *port) server->host = pkg_malloc(strlen(host)+1); if (server->host == NULL) { PKG_MEM_ERROR; + pkg_free(server); return -1; } strcpy(server->host, host); @@ -798,9 +799,14 @@ static int mod_init(void) return -1; } - global_id = (uint16_t*)shm_malloc(sizeof(uint16_t)); - - return 0; + global_id = (uint16_t*)shm_malloc(sizeof(uint16_t)); + if(!global_id) + { + SHM_MEM_ERROR; + shm_free(active); + return -1; + } + return 0; } static int child_init (int rank)