From ab5802239d850010b2f33a7b0a627232cd15e3b9 Mon Sep 17 00:00:00 2001 From: Daniel-Constantin Mierla Date: Mon, 13 Mar 2017 18:13:05 +0100 Subject: [PATCH] core: more safety checks for getting int values from cfg function params - related to GH #1011 (cherry picked from commit 97b3ce7c8991774f42c013122704f32e2822ac58) (cherry picked from commit fb859b9388ddfa82e7c6cf098940d920fead055b) --- sr_module.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/sr_module.c b/sr_module.c index 25da9cd298d..c72c6ff9dac 100644 --- a/sr_module.c +++ b/sr_module.c @@ -1723,6 +1723,7 @@ int get_int_fparam(int* dst, struct sip_msg* msg, fparam_t* param) case FPARAM_UNSPEC: case FPARAM_STRING: case FPARAM_STR: + LM_ERR("Unsupported param type for int value: %d\n", param->type); return -1; case FPARAM_AVP: avp = search_first_avp(param->v.avp.flags, param->v.avp.name, @@ -1759,6 +1760,10 @@ int get_int_fparam(int* dst, struct sip_msg* msg, fparam_t* param) } break; case FPARAM_PVE: + LM_ERR("Unsupported param type for int value: %d\n", param->type); + return -1; + default: + LM_ERR("Unexpected param type: %d\n", param->type); return -1; } return 0;