From b075e6fcb7435d168241bc9bc83e87b70b4d08d4 Mon Sep 17 00:00:00 2001 From: Henning Westerholt Date: Sun, 30 Dec 2018 01:17:15 +0100 Subject: [PATCH] core: fix an error in check_via_address, reported from Mojtaba, mespio at gmail dot com - fix an error in check_via_address, reported from Mojtaba, mespio at gmail dot com - use the same logic for IPv4 string comparison as for IPv6 - the old comparison could return true for e.g. via="192.168.1.1", src="192.1.1.100" - the new logic is also faster for the trivial case with different string length (cherry picked from commit 98ee014a88ca951d82a0389f0be119078ba525f7) --- src/core/msg_translator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/msg_translator.c b/src/core/msg_translator.c index 5b0c7263786..f34637b6f11 100644 --- a/src/core/msg_translator.c +++ b/src/core/msg_translator.c @@ -176,7 +176,7 @@ static int check_via_address(struct ip_addr* ip, str *name, LM_CRIT("invalid Via host name\n"); return -1; } - if (strncmp(name->s, s, name->len)==0) + if (len==name->len&&(strncmp(name->s, s, name->len)==0)) return 0; } }else{