diff --git a/src/modules/http_client/TODO.txt b/src/modules/http_client/TODO.txt index 3a23dd87311..d1a3617e68a 100644 --- a/src/modules/http_client/TODO.txt +++ b/src/modules/http_client/TODO.txt @@ -84,7 +84,7 @@ Development API match_header[len]= '\0'; https://curl.haxx.se/libcurl/c/CURLOPT_HEADERFUNCTION.html -- It also does get a headers from the reply, which needs a callback +- It also does get a header from the reply, which needs a callback - auth_identify sets the CURLOPT_CAINFO option https://curl.haxx.se/libcurl/c/CURLOPT_CAINFO.html This can be set in the httpconf object @@ -103,11 +103,11 @@ Solved issues -------------- - https://github.com/kamailio/kamailio/issues/541 - closed Support setting proxy - Comitted another patch, which included default and per-connection proxy + Committed another patch, which included default and per-connection proxy settings. - https://github.com/kamailio/kamailio/issues/515 - closed Support various auth methods - digest, basic etc - Comitted another patch, which included default and per-connection settings + Committed another patch, which included default and per-connection settings - https://github.com/kamailio/kamailio/pull/481 - closed Support TLS client certificates - https://github.com/kamailio/kamailio/pull/435 - closed diff --git a/src/modules/http_client/doc/http_client_admin.xml b/src/modules/http_client/doc/http_client_admin.xml index 446b68a00f7..9da71d5210e 100644 --- a/src/modules/http_client/doc/http_client_admin.xml +++ b/src/modules/http_client/doc/http_client_admin.xml @@ -23,7 +23,7 @@ servers and a set of settings that apply to the specific connection. - The http_client module has multiple settings, some of them applies to + The http_client module has multiple settings, some of them apply to a defined connection. You can set timeouts, max data sizes for download and much more either using modparam settings or parameters to the connection definition. @@ -46,7 +46,7 @@ this module. - The http_client module use the CURL library setting up connections. + The http_client module uses the CURL library setting up connections. The CURL library by default use the system configured DNS resolvers, not the Kamailio resolver. @@ -731,7 +731,7 @@ modparam("http_client", "netinterface", "eth0") <function>http_connect()</function> usage ... -modparam("http_client", "httpcon", "apiserver=>http://kamailio.org/api/"); +modparam("http_client", "httpcon", "apiserver=>https://kamailio.org/api/"); ... # POST Request $var(res) = http_connect("apiserver", "/mailbox", "application/json", "{ ok, {200, ok}}", "$avp(gurka)"); @@ -792,7 +792,7 @@ xlog("L_INFO", "API-server HTTP connection: $avp(route) Result code $var(res)\n" <function>http_connect_raw()</function> usage ... -modparam("http_client", "httpcon", "apiserver=>http://kamailio.org/api/"); +modparam("http_client", "httpcon", "apiserver=>https://kamailio.org/api/"); ... # POST Request $var(res) = http_connect_raw("apiserver", "/mailbox", "application/json", "{ ok, {200, ok}}", "$avp(gurka)"); @@ -863,7 +863,7 @@ http_get_redirect("apiserver", "$var(targeturl)"); the first line or the entire reply body (if any) is stored in result parameter, which must be a writable pseudo variable. See the query_result - parameter for controling what value to be stored in the result + parameter for controlling what value to be stored in the result variable. diff --git a/src/modules/http_client/http_client.c b/src/modules/http_client/http_client.c index 3064f5ac3e0..01c7067ae6f 100644 --- a/src/modules/http_client/http_client.c +++ b/src/modules/http_client/http_client.c @@ -693,7 +693,7 @@ static int ki_curl_connect_post_helper(sip_msg_t *_m, str *con, str *url, if(dst->setf) { dst->setf(_m, &dst->pvp, (int)EQ_T, &val); } else { - LM_WARN("target pv is not writtable\n"); + LM_WARN("target pv is not writable\n"); } if(result.s != NULL)