Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanity: Doesn't sent reply when some checks are failed. #1543

Closed
tiglat opened this issue May 24, 2018 · 7 comments

Comments

Projects
None yet
3 participants
@tiglat
Copy link
Contributor

commented May 24, 2018

Description

According the documentation the module will send reply if one of the checks is failed.
However it doesn't send reply if digest credentials, duplicated To/From tags or authorization header checks are failed.
I would like to propose to add a new parameter which will enable or disable auto sending of reply.

Reproduction

Send to kamailio request with empty nonce in Authorization header.

Possible Solutions

Set autodrop to 0 and send the reply from configuration file. But in some cases this reply will be sent twice from module and from config.

Additional Information

kamailio version 4.4.7 and the latest 5.x

@tiglat

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2018

I would like to update the information. In fact reply is sent rarely in case of to all checks. Probably it would be better to remove sending reply from the module at all. It could be easily done from a config script.

@henningw

This comment has been minimized.

Copy link
Contributor

commented May 25, 2018

Just an remark to your request: I noticed that the sanity module can't send a reply if the necessary header (e.g. To) to actually construct a reply are not present or corrupt. In this case sending a reply from the cfg will probably also not work.

@tiglat

This comment has been minimized.

Copy link
Contributor Author

commented May 25, 2018

Thank for explanation. You are right.

miconda added a commit that referenced this issue Sep 13, 2018

sanity: do not send reply if mandatory headers are missing
- reply cannot be constructed properly
- send replies in case of failures for digest checks (GH #1543)
- coherent use of msg vs _msg
@miconda

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

Pushed some commits to master branch, among changes is also sending reply for the checks you mentioned above.

If you can test the master branch and report the results, it would be appreciated. If all ok, it will be backported.

@henningw

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2018

Daniel - this is a great change, also as generic hardening against security issues.

@tiglat

This comment has been minimized.

Copy link
Contributor Author

commented Sep 13, 2018

Will test in few days.

@miconda

This comment has been minimized.

Copy link
Member

commented Sep 13, 2018

@tiglat ok, thanks! Reopen this ticket if it is same issue or open a new one if is something different. I am saying this because I just pushed more commits to sanity module, so it could be something else.

@miconda miconda closed this Sep 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.