Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog module: option to choose between OPTIONS or INVITE on keep-alive #1876

Closed
Fernandojdk opened this issue Mar 1, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@Fernandojdk
Copy link

commented Mar 1, 2019

Description

Enable dialog module to user choose between INVITE or OPTIONS on send Re-INVITE on keep-alive

Expected behavior

Make the dialog keep-alive through INVITE or OPTIONS. A user choice.

Possible Solutions

In function dlg_send_ka of dlg_req_within.c:445, provide an option to choose the value from module config var, pv value, dlg flag, etc.

File: dlg_req_within.c

435    /* send keep-alive
436     * dlg - pointer to a struct dlg_cell
437     * dir - direction: the request will be sent to:
438     * 		DLG_CALLER_LEG (0): caller
439     * 		DLG_CALLEE_LEG (1): callee
440     */
441    int dlg_send_ka(dlg_cell_t *dlg, int dir)
442    {
443    	uac_req_t uac_r;
444    	dlg_t* di;
445    	str met = {"INVITE", 6};
446    	int result;
447    	dlg_iuid_t *iuid = NULL;

Additional Information

Just for local tests, i changed dlg_req_within.c:445 from {"OPTIONS",7} to {"INVITE",6} and worked like a charm. I don't know if this change will affect other parts of kamailio.
Let me know if this change affect something else.

Thanks.

@miconda

This comment has been minimized.

Copy link
Member

commented Mar 4, 2019

In which scenario would this be useful? The goal of keepalive is to detect if the endpoint is still connected and it is aware of the dialog. It is not going to work like a session timer re-INVITE, if you are looking for such kind of feature. The keepalive requests are sent with "invalid" CSeq.

@miconda

This comment has been minimized.

Copy link
Member

commented Mar 11, 2019

Let's discuss this on sr-users@lists.kamailio.org mailing list to sort out why is needed, what are the side effects and the way to move forward.

@miconda miconda closed this Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.