Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db_redis: add support for native redis cluster #1997

Closed
gedia opened this issue Jul 1, 2019 · 3 comments
Closed

db_redis: add support for native redis cluster #1997

gedia opened this issue Jul 1, 2019 · 3 comments

Comments

@gedia
Copy link

gedia commented Jul 1, 2019

The db_redis module seems to only support connecting with a single redis instance. It is not evident from the documentation if it implements support for native redis cluster by honouring 'MOVED' replies.

ndb_redis seems to have support for native redis clusters, and supports both automatic (see allow_dynamic_nodes parameter of ndb_redis) and manual configuration of redis nodes.

Since both modules are based on the hiredis library, is it safe to assume this support could be easily implemented, with some code sharing between the two modules perhaps?

If db_redis supports clusters with automatic configuration only (by processing MOVED replies), perhaps the module's documentation should be updated to reflect that.

@miconda
Copy link
Member

miconda commented Jul 1, 2019

The two modules were developed independently. Maybe @agranig can comment if db_redis already supports or not processing MOVED replies.

@agranig
Copy link
Contributor

agranig commented Jul 1, 2019

Hey, unfortunately it doesn’t support it yet, and it’s not clear yet when I can address this, as I don’t have immediate needs for it.

@henningw
Copy link
Contributor

@gedia as there seems no interest from in implementing this feature right now, this issue will be closed. If somebody wants to work on this, please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants