Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p_usrloc: Fix #1265: missing columns in location.sql file. #1266

Merged
merged 1 commit into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@asiplas
Copy link
Contributor

commented Oct 8, 2017

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #1265

Description

Add columns referenced by p_usrloc_mod.c

@lbalaceanu lbalaceanu merged commit f9115fc into kamailio:master Oct 9, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@lbalaceanu

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2017

Thank you for your fix.

@miconda

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

Are these changes done first in the xml schema with table definition from src/lib/srdb1/schema? If done only in sql files, then it is done in the wrong place.

@lbalaceanu

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2017

Hello Daniel,

location.sql is the only changed file. I see in the src/lib/srdb1/schema/location.xml that this is documented as belonging to usrloc and that the columns are present there.

Should I create a similar xml for p_usrloc used tables?

Thank you

@miconda

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

Ohh, actually the sql file was in the module folder, I thought is in the utils/kamctl/{mysql,postgres,...}. So it is in the wrong place.

Yes, the best is to create xml definition as for location (usrloc module), then you can do make dbschema to get the sql files generated. You may need to update the Makefile in the schema folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.