Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes & improvements #1882

Merged
merged 8 commits into from Mar 9, 2019

Conversation

Projects
None yet
2 participants
@lazedo
Copy link
Contributor

commented Mar 5, 2019

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

  • added a worker_id for timer routines. when using rtimer in script with mode=4 there's no way to know which of the workers is in use. this is useful for db queries based on slot
  • fixed {uri.tosocket} transformation
  • added t_release_transaction to tm api
  • use t_release_transaction in tmx t_drop
  • fixed xavp_clone_level_nodata
  • add sockinfo to $subs
  • increase MAX_DEFINES as we run out of defines

Note: please use rebase instead of merge for this PR

to backport:

@henningw henningw self-assigned this Mar 7, 2019

@henningw

This comment has been minimized.

Copy link
Contributor

commented Mar 7, 2019

Hi, thank you for the request. I guess you mean "rebase and merge" instead of "squash and merge", understood. I will look tomorrow to it that we can get the backported fixes into the upcoming maintenance release. One question: can you explain a bit the reason for change e3ed896, especially why this needs to be backported?

@lazedo

This comment has been minimized.

Copy link
Contributor Author

commented Mar 8, 2019

i see it as a bug since tosocket is using msg to determine the transport instead of parsed uri from input, try to run it in a timer route and you'll see but i guess that it will also give wrong result if you receive a udp message and then try to apply the transform to "sip:xxx@yyy;transport=tcp". as for the backport, i think this is in 5.2 but not 5.1.

@henningw henningw merged commit 1ca82c1 into master Mar 9, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@henningw

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

Thank you for the explanation, request was merged. The necessary backports (three to 5.2, xavp clone issue to 5.1) were done as well.

@henningw

This comment has been minimized.

Copy link
Contributor

commented Mar 10, 2019

Could you add some documentation for 186d200 in the module README section 7 as well? Does the change in 20fc14f maybe needs to be documented in the wiki or module README as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.