Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small notes on $http_req(timeout) usage. #1913

Merged
merged 4 commits into from Mar 29, 2019

Conversation

Projects
None yet
3 participants
@samael33
Copy link
Contributor

commented Mar 28, 2019

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • [x ] Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Just small notes on $http_req(timeout) usage.

@grumvalski
Copy link
Contributor

left a comment

Thank you!
Just a small comment on the PR.

@grumvalski grumvalski merged commit 6224a38 into kamailio:master Mar 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@miconda

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@samael33, @grumvalski -- the commit messages on this pull are really inappropriate for development history.

Next time check the contribution guidelines:

@grumvalski

This comment has been minimized.

Copy link
Contributor

commented Mar 29, 2019

@samael33

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

@miconda

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

I rebased, edited the commits and then did a forced push -- worked this time, but this is usually dangerous to do, can break the repo. Better have the commit messages written properly.

@samael33

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.