Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lost: adds HELD (RFC6155) and LOST (RFC5222) queries for location-bas… #2031

Closed
wants to merge 1 commit into from

Conversation

@wkampich
Copy link
Contributor

commented Aug 12, 2019

…ed routing

  • lost_held_query() takes specific id (pvar, P-A-I, or From), assembles a
    locationRequest (XML), and sends it to an http_client connection, responses
    are parsed (pidf-lo and location reference are returned)
  • lost_query() takes pidf-lo (pvar, msg body, or de-referenced), a service urn
    (pvar, request line) assembles a findService request (XML), and sends it to
    an http_client connection, responses are parsed (target uri and display name
    are returned)

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

…ed routing

- lost_held_query() takes specific id (pvar, P-A-I, or From), assembles a
  locationRequest (XML), and sends it to an http_client connection, responses
  are parsed (pidf-lo and location reference are returned)
- lost_query() takes pidf-lo (pvar, msg body, or de-referenced), a service urn
  (pvar, request line) assembles a findService request (XML), and sends it to
  an http_client connection, responses are parsed (target uri and display name
  are returned)
@miconda

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Thanks! At a very quick look, code seems ok. I will let it here for a bit, just in case someone else wants to do a review, then it will be merged.

I will grant you commit access so your can manage the module yourself directly, once it is merged.

Copy link
Contributor

left a comment

Thank you Wolfgang, great contribution.

I have added a few comments, mainly to memory management, and some spelling/formatting fixes. I found nothing serious in my review. Would be great if you could have a look to them, after this the module should be committed to git master.

src/modules/lost/lost.c Show resolved Hide resolved
src/modules/lost/pidf.c Show resolved Hide resolved
src/modules/lost/pidf.c Show resolved Hide resolved
src/modules/lost/pidf.h Show resolved Hide resolved
src/modules/lost/utilities.c Show resolved Hide resolved
src/modules/lost/utilities.c Show resolved Hide resolved
src/modules/lost/utilities.c Show resolved Hide resolved
src/modules/lost/functions.c Show resolved Hide resolved
src/modules/lost/lost.c Show resolved Hide resolved
src/modules/lost/README Show resolved Hide resolved
@wkampich

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

Thank you Wolfgang, great contribution.

I have added a few comments, mainly to memory management, and some spelling/formatting fixes. I found nothing serious in my review. Would be great if you could have a look to them, after this the module should be committed to git master.

Dear Henning, many thanks for your comments - I'll definitely have a look at them.

@wkampich

This comment has been minimized.

Copy link
Contributor Author

commented Aug 14, 2019

Thank you Henning, I just pushed an updated version with your feedback incorporated.

@henningw

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@wkampich Thanks - did you pushed to the wkampich/lost branch in your fork? I just asked because it does not seems to be updated yet.

@wkampich

This comment has been minimized.

Copy link
Contributor Author

commented Aug 15, 2019

@wkampich Thanks - did you pushed to the wkampich/lost branch in your fork? I just asked because it does not seems to be updated yet.

I pushed it to the wkampich/lost fork yesterday and just did a new pull request

@henningw henningw self-assigned this Aug 16, 2019
@henningw

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Merged GH #2034, close this one.

@henningw henningw closed this Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.