Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lost: code review, updates to memory management and error handling #2034

Merged
merged 4 commits into from Aug 16, 2019

Conversation

@wkampich
Copy link
Contributor

commented Aug 15, 2019

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

wkampich added 4 commits Aug 12, 2019
…ed routing

- lost_held_query() takes specific id (pvar, P-A-I, or From), assembles a
  locationRequest (XML), and sends it to an http_client connection, responses
  are parsed (pidf-lo and location reference are returned)
- lost_query() takes pidf-lo (pvar, msg body, or de-referenced), a service urn
  (pvar, request line) assembles a findService request (XML), and sends it to
  an http_client connection, responses are parsed (target uri and display name
  are returned)
…ed routing

- code review, updates to memory managment and error handling
…ed routing

- code review, updates to memory managment and error handling
…ed routing

- header comment included
@wkampich wkampich changed the title lost: code review, updates to memory managment and error handling lost: code review, updates to memory management and error handling Aug 15, 2019
@henningw henningw self-assigned this Aug 16, 2019
@henningw henningw merged commit 3186694 into kamailio:master Aug 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@henningw

This comment has been minimized.

Copy link
Contributor

commented Aug 16, 2019

Thank you! As discussed, you can can do further extensions directly in git master.

@miconda

This comment has been minimized.

Copy link
Member

commented Aug 16, 2019

@henningw: from collaboration point of view, which in Kamailio we aim to do, before merging large pull requests, it is recommended to ask and see if someone else is planning to do a review, wait a bit for reactions, and then merge it if all ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.