Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pike: fixed regression #2744

Merged
merged 1 commit into from
May 26, 2021
Merged

pike: fixed regression #2744

merged 1 commit into from
May 26, 2021

Conversation

drTr0jan
Copy link
Contributor

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

There's an regression in 5.5 on pike.so. After c9dc033 the module has stopped to work. mark_node() had returned a NULL on every IP-address.

- removed unnecessary NULL-return from mark_node() after previous commit
@miconda
Copy link
Member

miconda commented May 25, 2021

Is this the fix for regression or just removal of an unnecessary return NULL? I understood from previous PR that the issues was with str case search.

@drTr0jan
Copy link
Contributor Author

@miconda, yep, it's the fix for regression. Pike (pike_check_req()) doesn't work without the fix at all. :(

It has nothing to do with previous PR (str case search). I've investigated the regression and found two issues (str case search and unnecessary NULL-return).

@miconda
Copy link
Member

miconda commented May 26, 2021

Thanks!

@miconda miconda merged commit 79fbb7c into kamailio:master May 26, 2021
@drTr0jan drTr0jan deleted the fix-pike branch May 26, 2021 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants