Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqueue: add two new module parameters #2825

Merged
merged 2 commits into from Aug 28, 2021
Merged

mqueue: add two new module parameters #2825

merged 2 commits into from Aug 28, 2021

Conversation

smititelu
Copy link
Contributor

@smititelu smititelu commented Aug 13, 2021

Pre-Submission Checklist

  • Commit message has the format required by CONTRIBUTING guide
  • Commits are split per component (core, individual modules, libs, utils, ...)
  • Each component has a single commit (if not, squash them into one commit)
  • No commits to README files for modules (changes must be done to docbook files
    in doc/ subfolder, the README file is autogenerated)

Type Of Change

  • Small bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would change existing functionality)

Checklist:

  • PR should be backported to stable branches
  • Tested changes locally
  • Related to issue #XXXX (replace XXXX with an open issue number)

Description

Add 2 new mqueue module parameters to simplify config queue definition.
Add 1 new rtimer module parameter to set default timeout if not present.
Updated docs.

smititelu added 2 commits Aug 13, 2021
Add mqueue_name and mqueue_size to define queues.
Updated doc.
Add default_interval to set the fire interval,
if interval not present inside timer string.
@miconda
Copy link
Member

@miconda miconda commented Aug 17, 2021

Thanks, however I can't see a relevant simplification of the config, but could be a matter of taste, not being a real technical matter -- instead of one modparam line with both queue name and size, now can be two modparams, one with name and one with size.

I will wait a little bit more to see if any other comments, then I can merge it.

@smititelu
Copy link
Contributor Author

@smititelu smititelu commented Aug 18, 2021

Hi Daniel,

Thanks for the input. Indeed not a real technical matter.

The actual usefulness of this is that after the commits one can set and use config #!defines for the new modparams (config "simplification" was not the right word; config "organization" is better).

Thank you,
Stefan

@miconda miconda merged commit 4368987 into kamailio:master Aug 28, 2021
7 checks passed
@DForester-FTC
Copy link

@DForester-FTC DForester-FTC commented Nov 4, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants