From f5cff8f16b7c006aa359527756f8a38783402b87 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD=20=D0=9F=D0=B0=D0=BB=D0=B0?= =?UTF-8?q?=D1=83=D0=B7=D0=BE=D0=B2?= Date: Sat, 4 Feb 2023 15:20:34 +0200 Subject: [PATCH 1/4] usrloc: typos --- src/modules/usrloc/doc/usrloc_admin.xml | 14 +++++++------- src/modules/usrloc/doc/usrloc_devel.xml | 2 +- src/modules/usrloc/udomain.c | 2 +- src/modules/usrloc/urecord.c | 2 +- src/modules/usrloc/urecord.h | 2 +- 5 files changed, 11 insertions(+), 11 deletions(-) diff --git a/src/modules/usrloc/doc/usrloc_admin.xml b/src/modules/usrloc/doc/usrloc_admin.xml index 2d3d8a17d42..ca2295ac67a 100644 --- a/src/modules/usrloc/doc/usrloc_admin.xml +++ b/src/modules/usrloc/doc/usrloc_admin.xml @@ -700,7 +700,7 @@ modparam("usrloc", "db_url", "&exampledb;") 4 - This uses database to load records at startup but uses only memory during the runtime. Records are not written back at all, not even at shutdown. Useful for scenarios when registrations are - replicated to a node that does the storage in database during + replicated to a node that does the storage in a database during runtime. @@ -730,8 +730,8 @@ modparam("usrloc", "db_mode", 2)
<varname>db_load</varname> (int) - Determine if the usrloc module should load contacts from the database storage during module initialization - A value of 0 disable the loading from the database, this parameter is ignored if db_mode 4 is set + Determine if the usrloc module should load contacts from the database storage during module initialization. + A value of 0 disables the loading from the database, this parameter is ignored if db_mode 4 is set. @@ -1323,7 +1323,7 @@ modparam("usrloc", "version_table", 0) Note: Keepalives will be sent to the IP and port using the transport - defined in the “received” column. If not set, then keepalives will be sent + defined in the received column. If not set, then keepalives will be sent to the AOR using UDP as a default transport. If available, the TCP connection will be re-used for WS, TCP and TLS. @@ -1755,7 +1755,7 @@ modparam("usrloc", "db_clean_tcp", 1) users Number of AOR existing in the USRLOC memory cache for that domain - - can not be reset; this statistic will be register for each + - can not be reset; this statistic will be registered for each used domain (Ex: location).
@@ -1763,7 +1763,7 @@ modparam("usrloc", "db_clean_tcp", 1) contacts Number of contacts existing in the USRLOC memory cache for that - domain - can not be reset; this statistic will be register for + domain - can not be reset; this statistic will be registered for each used domain (Ex: location). @@ -1771,7 +1771,7 @@ modparam("usrloc", "db_clean_tcp", 1) expires Total number of expired contacts for that domain - can be reset; - this statistic will be register for each used domain + this statistic will be registered for each used domain (Ex: location). diff --git a/src/modules/usrloc/doc/usrloc_devel.xml b/src/modules/usrloc/doc/usrloc_devel.xml index 856429f87a2..623daed8dc0 100644 --- a/src/modules/usrloc/doc/usrloc_devel.xml +++ b/src/modules/usrloc/doc/usrloc_devel.xml @@ -440,7 +440,7 @@ The function register with USRLOC a callback function to be called - when some event occures inside USRLOC. + when some event occurs inside USRLOC. Meaning of the parameters is as follows: diff --git a/src/modules/usrloc/udomain.c b/src/modules/usrloc/udomain.c index 6fc0c187dfb..f64df09daab 100644 --- a/src/modules/usrloc/udomain.c +++ b/src/modules/usrloc/udomain.c @@ -1295,7 +1295,7 @@ void mem_timer_udomain(udomain_t* _d, int istart, int istep) /*! * \brief Get lock for a domain * \param _d domain - * \param _aor adress of record, used as hash source for the lock slot + * \param _aor address of record, used as hash source for the lock slot */ void lock_udomain(udomain_t* _d, str* _aor) { diff --git a/src/modules/usrloc/urecord.c b/src/modules/usrloc/urecord.c index c06c5c4718d..aa43ac94b37 100644 --- a/src/modules/usrloc/urecord.c +++ b/src/modules/usrloc/urecord.c @@ -548,7 +548,7 @@ int db_delete_urecord_by_ruid(str *_table, str *_ruid) * \warning Failing to calls this function after get_urecord will * result in a memory leak when the DB_ONLY mode is used. When * the records is later deleted, e.g. with delete_urecord, then - * its not necessary, as this function already releases the record. + * it is not necessary, as this function already releases the record. * \param _r released record */ void release_urecord(urecord_t* _r) diff --git a/src/modules/usrloc/urecord.h b/src/modules/usrloc/urecord.h index 5ac7c9ae621..38e9cfa5114 100644 --- a/src/modules/usrloc/urecord.h +++ b/src/modules/usrloc/urecord.h @@ -135,7 +135,7 @@ int delete_urecord_by_ruid(udomain_t* _d, str *_ruid); * \warning Failing to calls this function after get_urecord will * result in a memory leak when the DB_ONLY mode is used. When * the records is later deleted, e.g. with delete_urecord, then - * its not necessary, as this function already releases the record. + * it is not necessary, as this function already releases the record. * \param _r released record */ void release_urecord(urecord_t* _r); From 898377afad50910a4edee3efeb24fbbbee33ad72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD=20=D0=9F=D0=B0=D0=BB=D0=B0?= =?UTF-8?q?=D1=83=D0=B7=D0=BE=D0=B2?= Date: Sat, 4 Feb 2023 15:27:39 +0200 Subject: [PATCH 2/4] src/lib: typos --- src/lib/Makefile.defs | 6 +++--- src/lib/README | 2 +- src/lib/binrpc/binrpc_api.c | 2 +- src/lib/binrpc/binrpc_api.h | 2 +- src/lib/cds/doc/destroy_sstream.xml | 4 ++-- src/lib/cds/dstring.h | 2 +- src/lib/cds/msg_queue.c | 2 +- src/lib/cds/msg_queue.h | 14 +++++++------- src/lib/cds/sstr.h | 2 +- src/lib/ims/ims_getters.c | 4 ++-- src/lib/ims/ims_getters.h | 4 ++-- src/lib/presence/notifier.h | 2 +- src/lib/presence/notifier_domain.c | 10 +++++----- src/lib/presence/subscriber.h | 4 ++-- src/lib/presence/xml_utils.c | 2 +- src/lib/srdb2/db_con.c | 2 +- src/lib/srdb2/db_gen.h | 4 ++-- src/lib/xcap/xcap_client.c | 2 +- src/lib/xcap/xml_utils.c | 2 +- 19 files changed, 36 insertions(+), 36 deletions(-) diff --git a/src/lib/Makefile.defs b/src/lib/Makefile.defs index 5155a522a32..f43592c4673 100644 --- a/src/lib/Makefile.defs +++ b/src/lib/Makefile.defs @@ -88,11 +88,11 @@ endif # @makedepend -fMakefile.deps -- ${DEFS} ${CFLAGS} ${INCLUDES} -- ${DEP_IN} 2>/dev/null # -@rm -f Makefile.deps.bak -# instalation rules +# installation rules ifeq ($(TYPE),lib) -# library instalation +# library installation install: ${out_name} install_dirs $(install-lib) ${out_name} $(lib-dir) @@ -104,7 +104,7 @@ install_dirs: $(lib-dir) $(include-dir)/$(NAME) else -# executable instalation +# executable installation install: ${out_name} install_dirs $(install-bin) ${out_name} $(bin-dir) diff --git a/src/lib/README b/src/lib/README index 9ca4cec11ba..f2d67b89ee0 100644 --- a/src/lib/README +++ b/src/lib/README @@ -14,7 +14,7 @@ Libraries common to modules: cds - Common Data Structures (basic string operations, dynamic string, vector, message queue, ...) -presence - Library holding common structures and functions abaut presence +presence - Library holding common structures and functions about presence (API for internal subscriptions, common presence structures, common presence data formats) requires internal libraries: cds diff --git a/src/lib/binrpc/binrpc_api.c b/src/lib/binrpc/binrpc_api.c index 02a52972001..032fbf18dc7 100644 --- a/src/lib/binrpc/binrpc_api.c +++ b/src/lib/binrpc/binrpc_api.c @@ -944,7 +944,7 @@ int binrpc_parse_response(struct binrpc_val** vals, int* val_count, *vals = NULL; } else if (i<*val_count){ -/* do not try to save memory because it causes fragmentation when used ser mem utils and "regualar" memory leak +/* do not try to save memory because it causes fragmentation when used ser mem utils and "regular" memory leak struct binrpc_val *t; t = (struct binrpc_val*) binrpc_realloc(*vals, i*sizeof(**vals)); if (t) *vals = t; diff --git a/src/lib/binrpc/binrpc_api.h b/src/lib/binrpc/binrpc_api.h index a2c31a7f336..910fa37b5cd 100644 --- a/src/lib/binrpc/binrpc_api.h +++ b/src/lib/binrpc/binrpc_api.h @@ -102,7 +102,7 @@ void binrpc_close_connection(struct binrpc_handle* handle); * Description: * The function send_command provides interface for communication with server * application via binary rpc protocol. It sends request over unix socket or - * TCP/UDPto the host and reads a respons. + * TCP/UDP to the host and reads a response. * * @param handle [in]: a descriptor of connection * @param method [in]: string value of XMLRPC method (e.g. system.listMethods) diff --git a/src/lib/cds/doc/destroy_sstream.xml b/src/lib/cds/doc/destroy_sstream.xml index 49b9df7ae7e..44aff1e8269 100644 --- a/src/lib/cds/doc/destroy_sstream.xml +++ b/src/lib/cds/doc/destroy_sstream.xml @@ -29,9 +29,9 @@ Description Destroys serialization stream and frees all internal data buffers. After calling -this function can NOT be called any other serialization stream manipulation +this function no other serialization stream manipulation function except init_input_sstream or -init_ouput_stream. +init_output_stream can be called. diff --git a/src/lib/cds/dstring.h b/src/lib/cds/dstring.h index 5dc2de5c914..dcafb16d0f1 100644 --- a/src/lib/cds/dstring.h +++ b/src/lib/cds/dstring.h @@ -62,7 +62,7 @@ typedef struct _dstr_buff_t { } dstr_buff_t; /** Dynamic string structure. It is used - * for muliple appends of any strings. + * for multiple appends of any string. * * \note There was an attempt to add flags for SHM/PKG memory using, ... * but it shows that it slows down, thus they were removed and only the diff --git a/src/lib/cds/msg_queue.c b/src/lib/cds/msg_queue.c index 8dd37f550a3..ec63cc3c547 100644 --- a/src/lib/cds/msg_queue.c +++ b/src/lib/cds/msg_queue.c @@ -166,7 +166,7 @@ int msg_queue_init_ex(msg_queue_t *q, int synchronize) } /** \internal Destroys all internal data of message queue and - * optionaly frees it if no more references exist. */ + * optionally frees it if no more references exist. */ static inline void msg_queue_destroy_and_free(msg_queue_t *q, int do_free) { mq_message_t *m,*n; diff --git a/src/lib/cds/msg_queue.h b/src/lib/cds/msg_queue.h index 9a1f8f6ab5b..7f2569e8e61 100644 --- a/src/lib/cds/msg_queue.h +++ b/src/lib/cds/msg_queue.h @@ -40,7 +40,7 @@ extern "C" { * Message queue is a structure useful for sending data between processes. * It can be synchronized via its own mutex or the synchronization can * be left on caller. It can use reference counter which is useful - * when accessing dynamicaly allocated queue destroyed by its last user. + * when accessing dynamically allocated queue destroyed by its last user. * * \todo To meaningfully use reference counters it is needed to add * function for adding new reference to message queue. @@ -54,12 +54,12 @@ typedef void (*destroy_function_f)(void *); /** Structure holding message which can be put * into message queue. * - * There is a need to allow destroing the message without knowing its + * There is a need to allow destroying the message without knowing its * internals (destroying message queue with non-processed messages) and thus * the destroy_function able to fully destroy whole data hold by message must * be given. It is mostly needed to choose the function manually only for * complex data with pointers which content need to be freed too. - * For simple structures it is set automaticaly during the message creation. + * For simple structures it is set automatically during the message creation. */ typedef struct _mq_message_t { /** pointer to data hold by the message */ @@ -122,14 +122,14 @@ typedef struct msg_queue { #define get_message_data_len(msg) (msg ? msg->data_len: 0) /** The space for data is allocated in messages data - * (they are automaticaly freed!)! Pointer to allocated + * (they are automatically freed!)! Pointer to allocated * data bytes is in data variable in the message structure. */ mq_message_t *create_message_ex(int data_len); /** Creates message holding data allocated using cds_malloc. * Data must be allocated using cds_malloc or there must be * set destroy function via \ref set_data_destroy_function - * because they are automaticaly freed by free_message! */ + * because they are automatically freed by free_message! */ mq_message_t *create_message(void *data, int data_len); /** Sets function which will be called by free_message to destroy data. @@ -140,7 +140,7 @@ void set_data_destroy_function(mq_message_t *msg, destroy_function_f func); /** Initializes message. * If auto_free set, data must be allocated using cds_malloc and are - * automaticaly freed by free_message (and if msg_queue_destroy called) */ + * automatically freed by free_message (and if msg_queue_destroy called) */ void init_message_ex(mq_message_t *m, void *data, int data_len, destroy_function_f func); /** Frees the message and data hold by the message. */ @@ -173,7 +173,7 @@ void msg_queue_init_ref_cnt(msg_queue_t *q, reference_counter_group_t *grp); /** Destroys message queue if no more references exist. * This function destroys all message queue internal data but doesn't free - * the message queue itself. It can be useful for staticaly allocated queues + * the message queue itself. It can be useful for statically allocated queues * or when allocated not using cds_malloc. */ void msg_queue_destroy(msg_queue_t *q); diff --git a/src/lib/cds/sstr.h b/src/lib/cds/sstr.h index 8ca5d27b4df..699ec094f51 100644 --- a/src/lib/cds/sstr.h +++ b/src/lib/cds/sstr.h @@ -53,7 +53,7 @@ typedef struct { #define str_len(ptr) ((ptr)?(ptr)->len:0) -/** transalate zero-terminated string to str_t (both uses the input buffer!)*/ +/** translate zero-terminated string to str_t (both uses the input buffer!)*/ str_t zt2str(char *str); /** returns 1 if the string is empty */ diff --git a/src/lib/ims/ims_getters.c b/src/lib/ims/ims_getters.c index 1e47e20e3da..4c5a6f452e1 100644 --- a/src/lib/ims/ims_getters.c +++ b/src/lib/ims/ims_getters.c @@ -943,8 +943,8 @@ struct via_body* cscf_get_first_via(struct sip_msg *msg,struct hdr_field **h) } /** - * Looks for the UE Via in First Via header if its a request - * or in the last if its a response and returns its body + * Looks for the UE Via in First Via header if it is a request + * or in the last if it is a response and returns its body * @param msg - the SIP message * @returns the via of the UE */ diff --git a/src/lib/ims/ims_getters.h b/src/lib/ims/ims_getters.h index 1ea36b3e241..0d9c42221ec 100644 --- a/src/lib/ims/ims_getters.h +++ b/src/lib/ims/ims_getters.h @@ -253,8 +253,8 @@ struct via_body* cscf_get_first_via(struct sip_msg *msg, struct hdr_field **h); */ struct via_body* cscf_get_last_via(struct sip_msg *msg); /** - * Looks for the UE Via in First Via header if its a request - * or in the last if its a response and returns its body + * Looks for the UE Via in First Via header if it is a request + * or in the last if it is a response and returns its body * @param msg - the SIP message * @returns the via of the UE */ diff --git a/src/lib/presence/notifier.h b/src/lib/presence/notifier.h index 0a425cde020..ab6b66a7aaa 100644 --- a/src/lib/presence/notifier.h +++ b/src/lib/presence/notifier.h @@ -44,7 +44,7 @@ notifier_t *register_notifier( void unregister_notifier(notifier_domain_t *domain, notifier_t *info); -/** accepts subscription (internaly adds reference to it), thus it can +/** accepts subscription (internally adds reference to it), thus it can * be handled by notifier which called this function * MUST be called in notifier's subscribe function, otherwise the * subscription can NOT be accepted diff --git a/src/lib/presence/notifier_domain.c b/src/lib/presence/notifier_domain.c index 65a919c798b..5f04aece7f3 100644 --- a/src/lib/presence/notifier_domain.c +++ b/src/lib/presence/notifier_domain.c @@ -121,7 +121,7 @@ static void destroy_package(notifier_package_t *p) s = ns; } - /* !!! don't release notifiers - its their job !!! */ + /* !!! don't release notifiers - it is their job !!! */ /* it may lead to errors there */ /* e = p->first_notifier; while (e) { @@ -230,7 +230,7 @@ static void remove_notifier_from_subscription(qsa_subscription_t *s, notifier_t for (i = 0; i < cnt; i++) { ss = vector_get_ptr(&s->server_subscriptions, i); if (!ss) continue; - / * FIXME: call n->unsubsribe ??? + / * FIXME: call n->unsubscribe ??? * NO this is called from unregister which is initiated * by the notifier (may be synchronized there!) * / if (ss->notifier == n) ss->notifier = NULL; / * "zombie" * / @@ -379,8 +379,8 @@ void unregister_notifier(notifier_domain_t *domain, notifier_t *info) /* -------- Subscriber functions -------- */ -/* If a notifier publishing watched state registeres after subscibe - * call, it receives the subscription automaticaly too! */ +/* If a notifier publishing watched state registers after subscribe + * call, it receives the subscription automatically too! */ qsa_subscription_t *subscribe(notifier_domain_t *domain, str_t *package, qsa_subscription_data_t *data) @@ -480,7 +480,7 @@ void unsubscribe(notifier_domain_t *domain, qsa_subscription_t *s) s->data = NULL; unlock_subscription_data(s); - /* remove clients reference (dont give references to client?) */ + /* remove clients reference (don't give references to client?) */ remove_reference(&s->ref); release_subscription(s); diff --git a/src/lib/presence/subscriber.h b/src/lib/presence/subscriber.h index 548b7724563..3f81158e878 100644 --- a/src/lib/presence/subscriber.h +++ b/src/lib/presence/subscriber.h @@ -34,8 +34,8 @@ extern "C" { #endif -/* If a notifier publishing watched state registeres after subscibe - * call, it receives the subscription automaticaly too! */ +/* If a notifier publishing watched state registers after subscribe + * call, it receives the subscription automatically too! */ /*qsa_subscription_t *subscribe(notifier_domain_t *domain, qsa_subscription_t *params);*/ qsa_subscription_t *subscribe(notifier_domain_t *domain, diff --git a/src/lib/presence/xml_utils.c b/src/lib/presence/xml_utils.c index 0b4ed558701..80f5e0f45f9 100644 --- a/src/lib/presence/xml_utils.c +++ b/src/lib/presence/xml_utils.c @@ -136,7 +136,7 @@ int cmp_node(xmlNode *node, const char *name, const char *nspace) time_t xmltime2time(const char *xt) { - /* TODO: translate XML time in input parametr to time_t structure */ + /* TODO: translate XML time in input parameter to time_t structure */ ERROR_LOG("can't translate xmltime to time_t: not finished yet!\n"); return 0; } diff --git a/src/lib/srdb2/db_con.c b/src/lib/srdb2/db_con.c index a540a370851..caa83232fd4 100644 --- a/src/lib/srdb2/db_con.c +++ b/src/lib/srdb2/db_con.c @@ -94,7 +94,7 @@ db_con_t* db_con(db_ctx_t* ctx, db_uri_t* uri) /* - * Releaase all memory used by the structure + * Release all memory used by the structure */ void db_con_free(db_con_t* con) { diff --git a/src/lib/srdb2/db_gen.h b/src/lib/srdb2/db_gen.h index 8166be28b20..d9e6e880ac7 100644 --- a/src/lib/srdb2/db_gen.h +++ b/src/lib/srdb2/db_gen.h @@ -139,7 +139,7 @@ struct db_drv; * * All variables and attributes to be shared across all DB API * structures should be put into this structure. This structure - * is at the beginnning of each DB API structure to ensure that + * is at the beginning of each DB API structure to ensure that * all DB API structures share some common variables. */ typedef struct db_gen { @@ -156,7 +156,7 @@ typedef struct db_gen { /* * Global variable holding the current index of the payload of the driver that - * is being executed. DB API is responsible for setting this vaiable before + * is being executed. DB API is responsible for setting this variable before * calling functions of DB drivers. */ extern int db_payload_idx; diff --git a/src/lib/xcap/xcap_client.c b/src/lib/xcap/xcap_client.c index 6c00c82a32b..57de8287808 100644 --- a/src/lib/xcap/xcap_client.c +++ b/src/lib/xcap/xcap_client.c @@ -190,7 +190,7 @@ int xcap_query(const char *uri, static size_t write_data_func(void *ptr, size_t size, size_t nmemb, void *stream) { int s = size * nmemb; -/* TRACE_LOG("%d bytes writen\n", s);*/ +/* TRACE_LOG("%d bytes written\n", s);*/ if (s != 0) { if (dstr_append((dstring_t*)stream, ptr, s) != 0) { ERROR_LOG("can't append %d bytes into data buffer\n", s); diff --git a/src/lib/xcap/xml_utils.c b/src/lib/xcap/xml_utils.c index 0b4ed558701..80f5e0f45f9 100644 --- a/src/lib/xcap/xml_utils.c +++ b/src/lib/xcap/xml_utils.c @@ -136,7 +136,7 @@ int cmp_node(xmlNode *node, const char *name, const char *nspace) time_t xmltime2time(const char *xt) { - /* TODO: translate XML time in input parametr to time_t structure */ + /* TODO: translate XML time in input parameter to time_t structure */ ERROR_LOG("can't translate xmltime to time_t: not finished yet!\n"); return 0; } From ce1b0694d038d30d5d2159fcdc31719a48abc799 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD=20=D0=9F=D0=B0=D0=BB=D0=B0?= =?UTF-8?q?=D1=83=D0=B7=D0=BE=D0=B2?= Date: Sat, 4 Feb 2023 15:28:48 +0200 Subject: [PATCH 3/4] acc: typos --- src/modules/acc/acc.c | 4 ++-- src/modules/acc/acc_api.h | 8 +++---- src/modules/acc/acc_logic.c | 6 +++--- src/modules/acc/acc_mod.c | 4 ++-- src/modules/acc/doc/acc_admin.xml | 36 +++++++++++++++---------------- src/modules/acc/doc/acc_faq.xml | 8 +++---- 6 files changed, 32 insertions(+), 34 deletions(-) diff --git a/src/modules/acc/acc.c b/src/modules/acc/acc.c index 1c1b07f6a98..6e9d8ed5a48 100644 --- a/src/modules/acc/acc.c +++ b/src/modules/acc/acc.c @@ -50,7 +50,7 @@ extern struct acc_extra *log_extra; extern struct acc_extra *leg_info; -extern struct acc_enviroment acc_env; +extern struct acc_environment acc_env; extern char *acc_time_format; extern int acc_extra_nullable; @@ -423,7 +423,7 @@ int acc_db_request( struct sip_msg *rq) struct tm t; double dtime; - /* formated database columns */ + /* formatted database columns */ m = core2strar( rq, val_arr, int_arr, type_arr ); for(i=0; ireq,RR_FLOW_UPSTREAM) ) { - LM_DBG("detected an UPSTREAM req -> flaging it\n"); + LM_DBG("detected an UPSTREAM req -> flagging it\n"); ps->req->msg_flags |= FL_REQ_UPSTREAM; } } @@ -642,7 +642,7 @@ static void acc_onreply(tm_cell_t *t, sip_msg_t *req, sip_msg_t *reply, int code if (hdr->parsed && hdr_allocs_parse(hdr) && (hdr->parsedparsed>=mend)) { /* header parsed filed doesn't point inside cloned request memory - * chunck -> it was added by resolving acc attributes -> free it as pkg */ + * chunk -> it was added by resolving acc attributes -> free it as pkg */ DBG("removing hdr->parsed %d\n", hdr->type); clean_hdr_field(hdr); hdr->parsed = 0; diff --git a/src/modules/acc/acc_mod.c b/src/modules/acc/acc_mod.c index 801a908025c..be87666f47e 100644 --- a/src/modules/acc/acc_mod.c +++ b/src/modules/acc/acc_mod.c @@ -348,13 +348,13 @@ static int parse_failed_filter(char *s, unsigned short *failed_filter) at = s; while ((*at >= '0') && (*at <= '9')) at++; if (at - s != 3) { - LM_ERR("respose code in failed_filter must have 3 digits\n"); + LM_ERR("response code in failed_filter must have 3 digits\n"); return 0; } failed_filter[n] = (*s - '0') * 100 + (*(s + 1) - '0') * 10 + (*(s + 2) - '0'); if (failed_filter[n] < 300) { - LM_ERR("invalid respose code %u in failed_filter\n", + LM_ERR("invalid response code %u in failed_filter\n", failed_filter[n]); return 0; } diff --git a/src/modules/acc/doc/acc_admin.xml b/src/modules/acc/doc/acc_admin.xml index f1dfbda6366..cd099c03ea0 100644 --- a/src/modules/acc/doc/acc_admin.xml +++ b/src/modules/acc/doc/acc_admin.xml @@ -36,7 +36,7 @@ module takes no acc-specific script command -- the functionality binds invisibly through transaction processing. Script writers just need to mark the transaction for accounting with proper setflag. - Even so, the module allows the script writter to force accounting in + Even so, the module allows the script writer to force accounting in special cases via some script functions. @@ -95,7 +95,7 @@ find out about it. In general, a better practice is to account from an end-device (such as PSTN gateway), which best knows about call status (including media status and PSTN status in case of the - gateway). However, CDR-base logging has the option to log existing + gateway). However, CDR-based logging has the option to log existing information from expired dialogs (the dlg_vars in cdr_extra) Please see cdr_expired_dlg_enable parameter - . @@ -220,13 +220,13 @@ if (uri=~"sip:+40") /* calls to Romania */ { A SIP call can have multiple legs due forwarding actions. For example user A calls user B which forwards the call to user C. - There is only one SIP call but with 2 legs ( A to B and B to C). + There is only one SIP call but with 2 legs (A to B and B to C). Accounting the legs of a call is required for proper billing of the calls (if C is a PSTN number and the call is billed, user B must pay for the call - as last party modifying the call destination-, and not A - as initiator of the call. Call forwarding on server is only one example which shows the - necessity of the having an accounting engine with multiple legs + necessity of having an accounting engine with multiple legs support. @@ -250,7 +250,7 @@ if (uri=~"sip:+40") /* calls to Romania */ { By default, the multiple call-leg support is disabled - it can be - enabled just be setting the per-leg set of AVPs via the + enabled just by setting the per-leg set of AVPs via the multi_leg_info module parameter. @@ -432,7 +432,7 @@ $dlg_var(callee) = $avp(callee); #callee='C'
&kamailio; Modules - The module depends on the following modules (in the other words + The module depends on the following modules (in other words the listed modules must be loaded before this module): @@ -494,7 +494,7 @@ modparam("acc", "early_media", 1) Per transaction flag which says if the transaction should be accounted also in case of failure (SIP status code >= 300). - This flag triggers accouting when the whole transaction fails + This flag triggers accounting when the whole transaction fails (on the server side). @@ -1057,10 +1057,8 @@ modparam("acc", "db_insert_mode", 1) The value can be: - - 0 - off (default). - 1 - on. - + 0 - off (default). + 1 - on. @@ -1094,10 +1092,10 @@ modparam("acc", "cdr_skip", "nocdr") Should CDR-based logging be enabled in case of expired dialogs? - - 0 - off (default). - 1 - on. - + + 0 - off (default). + 1 - on. + cdr_expired_dlg_enable example @@ -1113,10 +1111,10 @@ modparam("acc", "cdr_expired_dlg_enable", 1) Should the start time be taken from the time when the dialog is created, or when the dialog is confirmed? - - 0 - use time of dialog creation (default). - 1 - use time of dialog confirmation. - + + 0 - use time of dialog creation (default). + 1 - use time of dialog confirmation. + cdr_start_on_confirmed example diff --git a/src/modules/acc/doc/acc_faq.xml b/src/modules/acc/doc/acc_faq.xml index 9aeeec6fad7..7b27d9a0c1a 100644 --- a/src/modules/acc/doc/acc_faq.xml +++ b/src/modules/acc/doc/acc_faq.xml @@ -17,7 +17,7 @@ - What happened with old log_fmt parameter + What happened with old log_fmt parameter? @@ -31,7 +31,7 @@ - What happened with old multi_leg_enabled parameter + What happened with old multi_leg_enabled parameter? @@ -45,11 +45,11 @@ What happened with old src_leg_avp_id and dst_leg_avp_id - parameters + parameters? - The parameter was replaced by the more generic new parameter + The parameters were replaced by the more generic new parameter multi_leg_info. This allows logging (per-leg) of more information than just dst and src. From d0e3b34bc74d8c50031125c014fccf151cbc37e0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D0=94=D0=B8=D0=BB=D1=8F=D0=BD=20=D0=9F=D0=B0=D0=BB=D0=B0?= =?UTF-8?q?=D1=83=D0=B7=D0=BE=D0=B2?= Date: Sat, 4 Feb 2023 15:31:23 +0200 Subject: [PATCH 4/4] acc_diameter: typos --- src/modules/acc_diameter/acc_diameter_mod.c | 4 ++-- src/modules/acc_diameter/diam_avp.c | 4 ++-- src/modules/acc_diameter/diam_message.c | 2 +- src/modules/acc_diameter/diam_tcp.c | 2 +- src/modules/acc_diameter/doc/acc_diameter_admin.xml | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/modules/acc_diameter/acc_diameter_mod.c b/src/modules/acc_diameter/acc_diameter_mod.c index 5bdf0765dce..04cf17d1f4a 100644 --- a/src/modules/acc_diameter/acc_diameter_mod.c +++ b/src/modules/acc_diameter/acc_diameter_mod.c @@ -76,7 +76,7 @@ acc_engine_t _acc_diameter_engine; /* ----- DIAMETER acc variables ----------- */ -/*! \name AccDiamaterVariables Radius Variables */ +/*! \name AccDiameterVariables Radius Variables */ /*@{*/ int diameter_flag = -1; int diameter_missed_flag = -1; @@ -287,7 +287,7 @@ int acc_diam_init(acc_extra_t *leg_info) m = extra2int( leg_info, diam_attrs+n); if (m<0) { - LM_ERR("leg info names for DIAMTER must be integer AVP codes\n"); + LM_ERR("leg info names for DIAMETER must be integer AVP codes\n"); return -1; } n += m; diff --git a/src/modules/acc_diameter/diam_avp.c b/src/modules/acc_diameter/diam_avp.c index f8ad15a525e..aeb363f6430 100644 --- a/src/modules/acc_diameter/diam_avp.c +++ b/src/modules/acc_diameter/diam_avp.c @@ -53,7 +53,7 @@ void set_avp_fields( AAA_AVPCode code, AAA_AVP *avp) case 296: /*AVP Origin_Realm*/ case 400: /* AVP_Resource */ case 401: /* AVP_Response */ - case 402: /* AVP_Chalenge */ + case 402: /* AVP_Challenge */ case 403: /* AVP_Method */ case 404: /* Service_Type AVP */ case 405: /* User_Group AVP*/ @@ -62,7 +62,7 @@ void set_avp_fields( AAA_AVPCode code, AAA_AVP *avp) avp->type = AAA_AVP_STRING_TYPE; break; case 27: /*AVP_Session_Timeout*/ - case 258: /*AVP_Auth_Aplication_Id*/ + case 258: /*AVP_Auth_Application_Id*/ case 262: /*AVP_Redirect_Max_Cache_Time*/ case 265: /*AVP_Supported_Vendor_Id*/ case 266: /*AVP_Vendor_Id*/ diff --git a/src/modules/acc_diameter/diam_message.c b/src/modules/acc_diameter/diam_message.c index 098b51e9066..9b39d25c167 100644 --- a/src/modules/acc_diameter/diam_message.c +++ b/src/modules/acc_diameter/diam_message.c @@ -230,7 +230,7 @@ AAAMessage* AAATranslateMessage( unsigned char* source, unsigned int sourceLen, msg_len = get_3bytes( ptr ); ptr += MESSAGE_LENGTH_SIZE; if (msg_len>sourceLen) { - LM_ERR("AAA message len [%d] bigger then buffer len [%d]\n", + LM_ERR("AAA message len [%d] bigger than buffer len [%d]\n", msg_len,sourceLen); goto error; } diff --git a/src/modules/acc_diameter/diam_tcp.c b/src/modules/acc_diameter/diam_tcp.c index 19cf2c76e90..e7412533784 100644 --- a/src/modules/acc_diameter/diam_tcp.c +++ b/src/modules/acc_diameter/diam_tcp.c @@ -77,7 +77,7 @@ int init_mytcp(char* host, int port) if (connect(sfd, (const struct sockaddr *)&serv_addr, sizeof(serv_addr)) < 0) { - LM_ERR("failed to connec to the DIAMETER client\n"); + LM_ERR("failed to connect to the DIAMETER client\n"); close(sfd); return -1; } diff --git a/src/modules/acc_diameter/doc/acc_diameter_admin.xml b/src/modules/acc_diameter/doc/acc_diameter_admin.xml index f3bf9dd52f9..c2251c9a82b 100644 --- a/src/modules/acc_diameter/doc/acc_diameter_admin.xml +++ b/src/modules/acc_diameter/doc/acc_diameter_admin.xml @@ -46,7 +46,7 @@
&kamailio; Modules - The module depends on the following modules (in the other words + The module depends on the following modules (in other words the listed modules must be loaded before this module):