From f78188008db4bda1a7f6581f6d3508e4c3c978b4 Mon Sep 17 00:00:00 2001 From: Benjamin Tietz Date: Fri, 27 Oct 2023 10:35:33 +0200 Subject: [PATCH 1/2] http_client: add information about parameter loading - Inform that the order of the parameters is important when httpcon is loaded first --- src/modules/http_client/doc/http_client_admin.xml | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/modules/http_client/doc/http_client_admin.xml b/src/modules/http_client/doc/http_client_admin.xml index 1449dc824d8..aece60c529e 100644 --- a/src/modules/http_client/doc/http_client_admin.xml +++ b/src/modules/http_client/doc/http_client_admin.xml @@ -88,6 +88,13 @@
Parameters + + The parameters are loaded in order. That can lead to unexpected behavior: + If httpcon is set at first, the default values for all other paramters are used, + and not the values that might be set after httpcon. + For example, if setting verify_peer=0 or verify_host=0 after httpcon, + the certificates are checked and self-signed cirtificates are rejected nevertheless. +
<varname>httpredirect</varname> (int) From 2504faa13bc5d3914fc46ee650de0d8778cb3e23 Mon Sep 17 00:00:00 2001 From: Daniel-Constantin Mierla Date: Thu, 2 Nov 2023 13:09:15 +0100 Subject: [PATCH 2/2] http_client: docs - typos from previous commit --- src/modules/http_client/doc/http_client_admin.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/modules/http_client/doc/http_client_admin.xml b/src/modules/http_client/doc/http_client_admin.xml index aece60c529e..0e182cc95e3 100644 --- a/src/modules/http_client/doc/http_client_admin.xml +++ b/src/modules/http_client/doc/http_client_admin.xml @@ -90,10 +90,10 @@ Parameters The parameters are loaded in order. That can lead to unexpected behavior: - If httpcon is set at first, the default values for all other paramters are used, + If httpcon is set at first, the default values for all other parameters are used, and not the values that might be set after httpcon. For example, if setting verify_peer=0 or verify_host=0 after httpcon, - the certificates are checked and self-signed cirtificates are rejected nevertheless. + the certificates are checked and self-signed certificates are rejected nevertheless.
<varname>httpredirect</varname> (int)