New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with the first row in a menu #14

Open
jwensley2 opened this Issue Apr 1, 2013 · 8 comments

Comments

Projects
None yet
9 participants
@jwensley2

jwensley2 commented Apr 1, 2013

There seems to be a bug where the first row won't be activated when opening a menu a second time if it was the row that was open before closing the menu.

I tested using the example in the repository and it also contains the bug, so I know it's not my own code causing it.

Steps to reproduce using the example.

  1. Click the menu and hover over the first item 'Patas'.
  2. Move off to the left and click to close the menu.
  3. Click the menu again and hover to the first item, it won't activate this time.

If you hover over any item other than the first one before closing the menu the bug doesn't occur.

@gabriensymons

This comment has been minimized.

Show comment
Hide comment
@gabriensymons

gabriensymons Apr 3, 2013

Confirming the bug.

gabriensymons commented Apr 3, 2013

Confirming the bug.

@zaggwarrior

This comment has been minimized.

Show comment
Hide comment
@zaggwarrior

zaggwarrior Apr 4, 2013

I am confirming the bug. I have seen it as well.

From: Joseph Wensley [mailto:notifications@github.com]
Sent: Monday, April 01, 2013 3:20 PM
To: kamens/jQuery-menu-aim
Subject: [jQuery-menu-aim] Bug with the first row in a menu (#14)

There seems to be a bug where the first row won't be activated when opening a menu a second time if it was the row that was open before closing the menu.

I tested using the example in the repository and it also contains the bug, so I know it's not my own code causing it.

Steps to reproduce using the example.

  1. Click the menu and hover over the first item 'Patas'.
  2. Move off to the left and click to close the menu.
  3. Click the menu again and hover to the first item, it won't activate this time.

If you hover over any item other than the first one before closing the menu the bug doesn't occur.


Reply to this email directly or view it on GitHub #14 . https://github.com/notifications/beacon/K_MDP7qB5lTyeCFXcxQkMBQmehDGPYyQPi-EFyEvfP3ktR1IPn69TUnflhQPI6vI.gif

zaggwarrior commented Apr 4, 2013

I am confirming the bug. I have seen it as well.

From: Joseph Wensley [mailto:notifications@github.com]
Sent: Monday, April 01, 2013 3:20 PM
To: kamens/jQuery-menu-aim
Subject: [jQuery-menu-aim] Bug with the first row in a menu (#14)

There seems to be a bug where the first row won't be activated when opening a menu a second time if it was the row that was open before closing the menu.

I tested using the example in the repository and it also contains the bug, so I know it's not my own code causing it.

Steps to reproduce using the example.

  1. Click the menu and hover over the first item 'Patas'.
  2. Move off to the left and click to close the menu.
  3. Click the menu again and hover to the first item, it won't activate this time.

If you hover over any item other than the first one before closing the menu the bug doesn't occur.


Reply to this email directly or view it on GitHub #14 . https://github.com/notifications/beacon/K_MDP7qB5lTyeCFXcxQkMBQmehDGPYyQPi-EFyEvfP3ktR1IPn69TUnflhQPI6vI.gif

@o1egl

This comment has been minimized.

Show comment
Hide comment
@o1egl

o1egl Apr 30, 2013

You can fix it by return true from exitMenu param
exitMenu: function() {
//...........
return true;
}

o1egl commented Apr 30, 2013

You can fix it by return true from exitMenu param
exitMenu: function() {
//...........
return true;
}

@xamenrax

This comment has been minimized.

Show comment
Hide comment
@xamenrax

xamenrax Apr 30, 2013

It returns true by default, isn't it?

xamenrax commented Apr 30, 2013

It returns true by default, isn't it?

@shobson

This comment has been minimized.

Show comment
Hide comment
@shobson

shobson Aug 2, 2013

return true; seemed to fix the issue for me. Thanks.

shobson commented Aug 2, 2013

return true; seemed to fix the issue for me. Thanks.

@bobbyrenwick

This comment has been minimized.

Show comment
Hide comment
@bobbyrenwick

bobbyrenwick Oct 28, 2013

If you close your menu in any way other than the exitMenu function you will have this bug too. #41 solves that.

bobbyrenwick commented Oct 28, 2013

If you close your menu in any way other than the exitMenu function you will have this bug too. #41 solves that.

@emateu

This comment has been minimized.

Show comment
Hide comment
@emateu

emateu Jan 19, 2014

return true; seemed to fix the issue for me too. Thanks.

emateu commented Jan 19, 2014

return true; seemed to fix the issue for me too. Thanks.

@fruity4pie

This comment has been minimized.

Show comment
Hide comment
@fruity4pie

fruity4pie Oct 27, 2017

Just modify this area of code:

    var mouseenterRow = function() {
            if (timeoutId) {
                // Cancel any previous activation delays
                clearTimeout(timeoutId);
            }

            options.enter(this);
            possiblyActivate(this);
            options.activate(activeRow); ///////////////////////// ADD THIS LINE OF CODE ^^
        }

fruity4pie commented Oct 27, 2017

Just modify this area of code:

    var mouseenterRow = function() {
            if (timeoutId) {
                // Cancel any previous activation delays
                clearTimeout(timeoutId);
            }

            options.enter(this);
            possiblyActivate(this);
            options.activate(activeRow); ///////////////////////// ADD THIS LINE OF CODE ^^
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment