getters.border returns null #11

Open
arian opened this Issue Aug 9, 2012 · 0 comments

Comments

Projects
None yet
1 participant
Contributor

arian commented Aug 9, 2012

See https://github.com/kamicane/moofx/blob/master/lib/browser.js#L317

This makes sense if you want to get the border property. However when animating the border, when one border (for example the top) is different, it will return null which causes an error here: https://github.com/kamicane/moofx/blob/master/lib/browser.js#L567 (because null doesn't have a replace method).

I think when it's detected that the borders are different, it should change

{
     border: '1px solid red'
}
// into
{
     borderTop: '1px solid red',
     borderRight: '1px solid red',
     borderBottom: '1px solid red',
     borderLeft: '1px solid red'
}

so all borders do animate to the desired value, and it would prevent the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment