default_per_page remains static #280

Closed
radar opened this Issue Sep 5, 2012 · 12 comments

Projects

None yet

9 participants

@radar
radar commented Sep 5, 2012

I'm running the tests for Spree's master branch using Kaminari 0.14.0 and I'm getting a failure which is caused by the change in @eaca75e. During the test, I am resetting default_per_page and it seems that kaminari is not acknowledging this change.

How can I fix this problem?

@radar radar added a commit to spree/spree that referenced this issue Sep 5, 2012
@radar radar Freeze to kaminari 0.13.0 until kaminari/kaminari#280 is fixed bd549ec
@radar radar added a commit to spree/spree that referenced this issue Sep 5, 2012
@radar radar Freeze to kaminari 0.13.0 until kaminari/kaminari#280 is fixed dbb0c56
@radar radar added a commit to spree/spree that referenced this issue Sep 5, 2012
@radar radar Freeze to kaminari 0.13.0 until kaminari/kaminari#280 is fixed 3b4e1de
Contributor

Where in spree you are doing this? Maybe looking at your code it can be easier to fix. =D

radar commented Sep 5, 2012

Sorry!

This is the test that is failing with kaminari 0.14.0 and this is the default_per_page helper that we use in the spec

swalke16 commented Sep 6, 2012

Seeing the same issue in our tests locally around one of our controllers.

Kaminari.configure { |config| config.default_per_page = 2 }

in a before block does not seem to actually cause the pagination to actually return only two items per page.

Owner
yuki24 commented Sep 7, 2012

I just pull-requested as #282 for the fix!

Contributor

👍

Owner
amatsuda commented Sep 8, 2012

Oops! Sorry for the breakage, and thank you for your prompt report and fix!
The #282 fix was just merged and will be in the next gem package coming soon.

@amatsuda amatsuda closed this Sep 8, 2012
radar commented Sep 8, 2012

It's alright :) thanks for acknowledging the bug and fixing it!

On 08/09/2012, at 2:18, Akira Matsuda notifications@github.com wrote:

Oops! Sorry for the breakage, and thank you for your prompt report and fix!
The #282 fix was just merged and will be in the next gem package coming soon.


Reply to this email directly or view it on GitHub.

graywh commented Sep 26, 2012

Sorry, but this is still not working for me, using either syntax to change the global default_per_page.

@andrewle andrewle added a commit to andrewle/kaminari that referenced this issue Mar 16, 2013
@andrewle andrewle Merge remote-tracking branch 'upstream/master'
* upstream/master:
  Fix typo: shold -> should
  Use rdoc markup in code
  Fix coercion error when offset_value is nil
  Revert @eaca75e for kaminari/kaminari#280 again
226bffc
@zzak zzak reopened this Oct 25, 2013
Owner
yuki24 commented Nov 3, 2013

This issue has been solved by 17892d6. The real issue is that we haven't released a new version for a long time...

@yuki24 yuki24 closed this Nov 3, 2013
Member
zzak commented Nov 3, 2013

@yuki24 I re-opened it because I wanted to check on mongoid

@zzak zzak reopened this Nov 3, 2013

@yuki24 Could you please release a new version with this included? I'm a bit afraid to switch to master just to have the right test behavior.

Contributor
wbyoung commented Nov 12, 2013

Master should be stable, and from the talk around here, there should be a release once a few more issues have been sorted out.

@yuki24 yuki24 added a commit that closed this issue Nov 19, 2013
@yuki24 yuki24 Add tests for configuration methods
This commit also includes fix for configuration methods of DataMapper and MongoMapper collection. Closes #280.
408d26d
@yuki24 yuki24 closed this in 408d26d Nov 19, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment