Enable passing html_options to pagination links #351

Closed
deiga opened this Issue Feb 2, 2013 · 4 comments

Projects

None yet

3 participants

@deiga
deiga commented Feb 2, 2013

Today I tried to add 'data-pjax' => true to paginate @users, but was greeted with an error. It seems to me that kaminari doesn't support passing custom html_options so this would be a nice feature :)

@yuki24
Member
yuki24 commented Feb 3, 2013

That sounds reasonable to me. But can you edit kaminari templates directly for now?

Anyway, if we add html_options option, we will possibly remove remote option.

@deiga
deiga commented Feb 3, 2013

Yeah, I know that I can edit templates, but it's tedious and repetitive :) not DRY at all :)
well yeah paginate @users, remote: true would become paginate @users, html_option: {remote:true} etc.

@deiga
deiga commented Feb 6, 2013

I'll try and work on this. I am toying with the idea of making paginate act more like link_to, so it would would take args* as parameter and then parse the model, kaminari_options and html_options out of it.

If you got suggestions or objections, please input :)

@zzak
Member
zzak commented Aug 7, 2013

We are work on this for the next major release.

@zzak zzak closed this Aug 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment